From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754412AbbBZVxK (ORCPT ); Thu, 26 Feb 2015 16:53:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43397 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539AbbBZVxH (ORCPT ); Thu, 26 Feb 2015 16:53:07 -0500 Date: Thu, 26 Feb 2015 16:52:51 -0500 From: Benjamin Tissoires To: Vince Herried Cc: linux-input@vger.kernel.org, DIGImend-devel , Jiri Kosina , Nikolai Kondrashov , linux-kernel@vger.kernel.org Subject: Re: [DIGImend-devel] [PATCH 3/4].... Message-ID: <20150226215251.GB7092@mail.corp.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vince, On Feb 26 2015 or thereabouts, Vince Herried wrote: > I'm overwhelmed by these updates My understanding of the code is not that > good. > > Currently i have a version of the code that gives two interfaces from my > Huion h610. I have gotten the buttons to work using xsetwacom. I dont > want to lose button function. > > Q1. Will the changes from Benjamin preserve button functionality? It depend what you call button functionality. My goal is to get rid of the keyboard shortcuts that are emitted by the device out of the box. It is a really bad idea from the firmware engineers and you don't get the release information on each button. If you are using the branch huion-abstract-keyboard on the digimend-kernel-drivers tree, then this is what we should end up. Currently these patch series give little enhancement with respect to what is currently upstream (these are upstream patches). The only difference from what you will get from a plain v3.19 kernel is that there will be some suffixes added to the name of the input nodes (some more appeared because we can not be sure that we don't need them). On my H610 Pro, I have: $ xinput ⎡ Virtual core pointer id=2 [master pointer (3)] ⎜ ↳ HUION PenTablet Pen id=9 [slave pointer (2)] ⎜ ↳ HUION PenTablet Mouse id=10 [slave pointer (2)] ⎣ Virtual core keyboard id=3 [master keyboard (2)] ↳ HUION PenTablet Keyboard id=11 [slave keyboard (3)] ↳ HUION PenTablet System Control id=12 [slave keyboard (3)] ↳ HUION PenTablet Consumer Control id=13 [slave keyboard (3)] Of course, I receive events only on the Pen and Keyboard interface. > > Q2. I want to help where should i grab test versions? I just pushed the 6 patches of the v2 series on top of a v4.0-rc1 kernel merged with Jiri's tree (the official hid tree): https://github.com/bentiss/linux branch huion.v2-4.0-rc1 But that means that you need to recompile the whole kernel for the tests. You can try to copy/paste drivers/hid/hid-uclogic.c into your local digimend-kernel-drivers tree and then run make. Depending on your running kernel, it might work, or not :( When this will be merged upstream, I'll send the equivalent patches for the digimend tree, plus the rebase of huion-abstract-keyboard on top of that. Cheers, Benjamin