From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365AbbB0U6u (ORCPT ); Fri, 27 Feb 2015 15:58:50 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:54046 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932274AbbB0U6r (ORCPT ); Fri, 27 Feb 2015 15:58:47 -0500 Date: Fri, 27 Feb 2015 15:58:45 -0500 (EST) Message-Id: <20150227.155845.171916200094175034.davem@davemloft.net> To: mst@redhat.com Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org Subject: Re: [PATCH] vhost: cleanup iterator update logic From: David Miller In-Reply-To: <1424795477-6820-1-git-send-email-mst@redhat.com> References: <1424795477-6820-1-git-send-email-mst@redhat.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Fri, 27 Feb 2015 12:58:47 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Tue, 24 Feb 2015 17:31:31 +0100 > Recent iterator-related changes in vhost made it > harder to follow the logic fixing up the header. > In fact, the fixup always happens at the same > offset: sizeof(virtio_net_hdr): sometimes the > fixup iterator is updated by copy_to_iter, > sometimes-by iov_iter_advance. > > Rearrange code to make this obvious. > > Signed-off-by: Michael S. Tsirkin Applied.