Re: [PATCH v5 3/3] tools lib traceevent: Add support for __print_array()

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 27 Feb 2015 12:32:32 +0000
Javi Merino <javi.merino@arm.com> wrote:

> Hi Steve,
> 
> On Wed, Jan 28, 2015 at 12:48:55PM +0000, Javi Merino wrote:
> > Trace can now generate traces with variable element size arrays.  Add
> > support to parse them.
> > 
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: Steven Rostedt <rostedt@goodmis.org>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> > Signed-off-by: Javi Merino <javi.merino@arm.com>
> > ---
> >  tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++
> >  tools/lib/traceevent/event-parse.h |  8 ++++
> >  2 files changed, 101 insertions(+)
> 
> I've seen that patch 1 of this series is now in mainline.  What about
> patches 2 and 3 (the updates to tools/lib/traceevent)?  Shall I resend
> them?

Patches 2 and 3 are in tools/lib and need to go through Jiri and
Arnaldo. Please repost them again. I can give them acks.

> 
> These two patches should also be applied to trace-cmd.  Do you want me
> to send patches for that to linux-kernel or will you take care of
> applying them there?

No need, I can pull them from here. I just been a bit busy to do so.

> 
> Incidentally, why are there two copies of libtraceevent?  Shouldn't
> this live only in one place (either kernel or trace-cmd)?

Actually, libtraceevent does not exist in trace-cmd, just the event
parsing code. libtraceevent needs to be packaged up and supplied as a
library. That's on our todo list, but never seems to get done :-/

Until libtraceevent is provided by all distros, there will continue to
be duplicate code. And it's not just with these two tools. I can think
of two other tools that also share this code for parsing. It really
does need to get packaged up.

-- Steve