From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755294AbbB0UTG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Feb 2015 15:19:06 -0500
Received: from smtprelay0020.hostedemail.com ([216.40.44.20]:47296 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753405AbbB0UTE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Feb 2015 15:19:04 -0500
X-Session-Marker: 6E657665747340676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1538:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2895:3138:3139:3140:3141:3142:3350:3622:3865:3866:3867:3868:3870:3871:3872:3874:4250:5007:6261:7875:7903:10004:10400:10848:10967:11232:11658:11914:12517:12519:12663:12740:13069:13161:13229:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: veil06_31de1e6e7831d
X-Filterd-Recvd-Size: 1596
Date: Fri, 27 Feb 2015 15:19:01 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] x86_32: Initialize the cr4 shadow on cpu init
Message-ID: <20150227151901.5ddd3c74@gandalf.local.home>
In-Reply-To: <9f46c973be1f0209d8e1c6ad1dc96fd663aea330.1425066715.git.luto@amacapital.net>
References: <CA+55aFw__pp_ivEsX3o_7OUhLV6ROvVq_vdsxNHv2DgvTCYVqg@mail.gmail.com>
	<9f46c973be1f0209d8e1c6ad1dc96fd663aea330.1425066715.git.luto@amacapital.net>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 27 Feb 2015 11:53:39 -0800
Andy Lutomirski <luto@amacapital.net> wrote:

> This is embarrassing.  I must have gotten lucky testing it.
> 

The thing is, it booted fine on all my tests. It wasn't until I did
hotplug where it crashed.

I'm not sure what's in CR4 when the CPU comes up, but perhaps zero is
fine to start out and the writes to CR4 update makes the shadow and reg
the same. It's when we hotplug that the two become out of sync.

Just my theory.

-- Steve