mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Cc: <gregkh@linuxfoundation.org>, <balbi@ti.com>,
	<laurent.pinchart@ideasonboard.com>,
	<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb/isp1760: set IRQ flags properly
Date: Fri, 27 Feb 2015 09:24:35 -0600	[thread overview]
Message-ID: <20150227152435.GA22183@saruman.tx.rr.com> (raw)
In-Reply-To: <1425043780-21773-1-git-send-email-Valentin.Rothberg@lip6.fr>

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote:
> The IRQF_DISABLED is a NOOP and scheduled to be removed.  According to
> commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled)
> running IRQ handlers with interrupts enabled can cause stack overflows
> when the interrupt line of the issuing device is still active.
> 
> This patch removes using this deprecated flag and additionally removes
> redundantly setting IRQF_SHARED.

why is it redundant ?

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-02-27 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-27 13:29 Valentin Rothberg
2015-02-27 15:24 ` Felipe Balbi [this message]
2015-02-27 15:48   ` Valentin Rothberg
2015-02-27 15:51     ` Felipe Balbi
2015-03-01 15:54 ` [PATCH v2] " Valentin Rothberg
2015-03-02 15:30   ` laurent.pinchart
2015-03-04  9:15     ` Valentin Rothberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227152435.GA22183@saruman.tx.rr.com \
    --to=balbi@ti.com \
    --cc=Valentin.Rothberg@lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®