From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755554AbbB0WJt (ORCPT <rfc822;w@1wt.eu>);
	Fri, 27 Feb 2015 17:09:49 -0500
Received: from casper.infradead.org ([85.118.1.10]:37315 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755532AbbB0WJs (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 27 Feb 2015 17:09:48 -0500
Date: Fri, 27 Feb 2015 23:09:39 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Tim Chen <tim.c.chen@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>,
        Andi Kleen <andi@firstfloor.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Srivatsa S.Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smp: Remove CSD_FLAG_WAIT flag that's unused
Message-ID: <20150227220939.GU5029@twins.programming.kicks-ass.net>
References: <1425069373.9530.155.camel@schen9-desk2.jf.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1425069373.9530.155.camel@schen9-desk2.jf.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 27, 2015 at 12:36:13PM -0800, Tim Chen wrote:
> 
> The CSD_FLAG_WAIT is not serving any useful purpose as we do not use
> its value to decide if we are going to wait for a smp call to complete.
> We also never cleared it properly when we are done waiting to indicate
> that the wait is over.  So the WARNING debug check in csd_unlock is
> also not serving useful purpose.  Propose here to remove it to clean up
> the code.

Linus had a much more comprehensive patch:

  http://marc.info/?l=linux-kernel&m=142368734118230