From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752564AbbCAQl3 (ORCPT ); Sun, 1 Mar 2015 11:41:29 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:45961 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751435AbbCAQl2 (ORCPT ); Sun, 1 Mar 2015 11:41:28 -0500 Date: Sun, 1 Mar 2015 08:41:26 -0800 From: Greg KH To: Matteo Semenzato Cc: lidza.louina@gmail.com, markh@compro.net, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: dgnc: replace printk Message-ID: <20150301164126.GB29474@kroah.com> References: <1425198701-32702-1-git-send-email-mattew8898@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425198701-32702-1-git-send-email-mattew8898@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 01, 2015 at 09:31:41AM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the following warning: > Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, > ... then pr_err(... to printk(KERN_ERR ... > > Signed-off-by: Matteo Semenzato > --- > drivers/staging/dgnc/dgnc_sysfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dgnc_sysfs.c b/drivers/staging/dgnc/dgnc_sysfs.c > index 2fd34ca..0fa2388 100644 > --- a/drivers/staging/dgnc/dgnc_sysfs.c > +++ b/drivers/staging/dgnc/dgnc_sysfs.c > @@ -91,7 +91,7 @@ void dgnc_create_driver_sysfiles(struct pci_driver *dgnc_driver) > rc |= driver_create_file(driverfs, &driver_attr_maxboards); > rc |= driver_create_file(driverfs, &driver_attr_pollrate); > if (rc) > - printk(KERN_ERR "DGNC: sysfs driver_create_file failed!\n"); > + pr_err("DGNC: sysfs driver_create_file failed!\n"); > } > > > @@ -360,7 +360,7 @@ void dgnc_create_ports_sysfiles(struct dgnc_board *bd) > rc |= device_create_file(&(bd->pdev->dev), &dev_attr_vpd); > rc |= device_create_file(&(bd->pdev->dev), &dev_attr_serial_number); > if (rc) > - printk(KERN_ERR "DGNC: sysfs device_create_file failed!\n"); > + pr_err("DGNC: sysfs device_create_file failed!\n"); Why can't you use dev_err() here?