From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754832AbbCBUEM (ORCPT ); Mon, 2 Mar 2015 15:04:12 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:53315 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754554AbbCBUEJ (ORCPT ); Mon, 2 Mar 2015 15:04:09 -0500 Date: Mon, 02 Mar 2015 15:04:05 -0500 (EST) Message-Id: <20150302.150405.2072800922470200977.davem@davemloft.net> To: mhocko@suse.cz Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hannes@cmpxchg.org, rientjes@google.com, david@fromorbit.com, tytso@mit.edu, mgorman@suse.de, penguin-kernel@I-love.SAKURA.ne.jp, sparclinux@vger.kernel.org, vipul@chelsio.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 3/4] sparc: remove __GFP_NOFAIL reuquirement From: David Miller In-Reply-To: <1425304483-7987-4-git-send-email-mhocko@suse.cz> References: <1425304483-7987-1-git-send-email-mhocko@suse.cz> <1425304483-7987-4-git-send-email-mhocko@suse.cz> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Mon, 02 Mar 2015 12:04:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Hocko Date: Mon, 2 Mar 2015 14:54:42 +0100 > mdesc_kmalloc is currently requiring __GFP_NOFAIL allocation although it > seems that the allocation failure is handled by all callers (via > mdesc_alloc). __GFP_NOFAIL is a strong liability for the memory > allocator and so the users are discouraged to use the flag unless the > allocation failure is really a nogo. Drop the flag here as this doesn't > seem to be the case. > > Signed-off-by: Michal Hocko It is a serious failure. If we miss an MDESC update due to this allocation failure, the update is not an event which gets retransmitted so we will lose the updated machine description forever. We really need this allocation to succeed.