From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbbCBBbA (ORCPT ); Sun, 1 Mar 2015 20:31:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:51567 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbbCBBa6 (ORCPT ); Sun, 1 Mar 2015 20:30:58 -0500 Date: Sun, 1 Mar 2015 17:30:57 -0800 From: Greg KH To: Alberto Pires de Oliveira Neto Cc: oleg.drokin@intel.com, andreas.dilger@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: lustre: fld_request.c: Remove else after return. Message-ID: <20150302013057.GA3395@kroah.com> References: <1425141443-20534-1-git-send-email-mrpenguin2005@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425141443-20534-1-git-send-email-mrpenguin2005@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 28, 2015 at 01:37:23PM -0300, Alberto Pires de Oliveira Neto wrote: > This patch fixes checkpatch.pl warning. > WARNING: else is not generally useful after a break or return > > Signed-off-by: Alberto Pires de Oliveira Neto > --- > drivers/staging/lustre/lustre/fld/fld_request.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/fld/fld_request.c b/drivers/staging/lustre/lustre/fld/fld_request.c > index b8d17e1..0b00301 100644 > --- a/drivers/staging/lustre/lustre/fld/fld_request.c > +++ b/drivers/staging/lustre/lustre/fld/fld_request.c > @@ -217,10 +217,9 @@ int fld_client_add_target(struct lu_client_fld *fld, > CERROR("%s: Attempt to add target %s (idx %llu) on fly - skip it\n", > fld->lcf_name, name, tar->ft_idx); > return 0; > - } else { > - CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n", > - fld->lcf_name, name, tar->ft_idx); > - } > + } > + CDEBUG(D_INFO, "%s: Adding target %s (idx %llu)\n", > + fld->lcf_name, name, tar->ft_idx); > > OBD_ALLOC_PTR(target); > if (target == NULL) Never add new checkpatch errors when trying to fix checkpatch errors, as you will never end up removing them... Please fix and resend.