From: Peter Zijlstra <peterz@infradead.org>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86: do not save callee-preserved registers around lockdep_sys_exit_thunk
Date: Mon, 2 Mar 2015 09:45:02 +0100 [thread overview]
Message-ID: <20150302084502.GE5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CALCETrVTU7Ji9UOdEnBH7pjKOGLFh1+DXQCo69HGs+ZFEkPa6A@mail.gmail.com>
On Sun, Mar 01, 2015 at 08:16:18AM -0800, Andy Lutomirski wrote:
> On Fri, Feb 27, 2015 at 4:29 PM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> > Internally, lockdep_sys_exit_thunk saves callee-clobbered registers,
> > and calls a C function, lockdep_sys_exix. Thus, callee-preserved
> > won't be mangled, there is no need to save them.
> >
> > Patch was run-tested.
>
> Peterz, I think this was your code.
It was, I'm forever unsure on when what register are saved by which
macros/functions.
Thanks!
next prev parent reply other threads:[~2015-03-02 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 0:29 [PATCH 0/3] " Denys Vlasenko
2015-02-28 0:29 ` [PATCH 1/3] x86: move ARCH_LOCKDEP_SYS_EXIT[IRQ] defines closer to their users Denys Vlasenko
2015-02-28 0:29 ` [PATCH 2/3] x86: fold ARCH_LOCKDEP_SYS_EXIT defines into " Denys Vlasenko
2015-02-28 0:29 ` [PATCH 3/3] x86: do not save callee-preserved registers around lockdep_sys_exit_thunk Denys Vlasenko
2015-03-01 16:16 ` Andy Lutomirski
2015-03-02 8:45 ` Peter Zijlstra [this message]
2015-03-25 20:14 [PATCH 0/3] " Denys Vlasenko
2015-03-25 20:14 ` [PATCH 3/3] " Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150302084502.GE5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome