From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbbCBOKt (ORCPT ); Mon, 2 Mar 2015 09:10:49 -0500 Received: from smtprelay0199.hostedemail.com ([216.40.44.199]:53058 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751687AbbCBOKs (ORCPT ); Mon, 2 Mar 2015 09:10:48 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1434:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2692:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6261:7875:7903:8660:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12295:12296:12438:12517:12519:12555:12740:13148:13230:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: laugh94_40e891c0bc151 X-Filterd-Recvd-Size: 3229 Date: Mon, 2 Mar 2015 09:10:44 -0500 From: Steven Rostedt To: Hou Pengyang Cc: , , Subject: Re: [PATCH] ftrace: Fix comments about trace/ftrace.h Message-ID: <20150302091044.0039be5e@gandalf.local.home> In-Reply-To: <1425306534-161763-1-git-send-email-houpengyang@huawei.com> References: <1425306534-161763-1-git-send-email-houpengyang@huawei.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Mar 2015 14:28:54 +0000 Hou Pengyang wrote: > commit f42c85e74faa422cf0bc747ed808681145448f88 moves tracepoint's ftrace > creation into include/trace/ftrace.h and trace/define_trach.h is deleted You mean event_trace.h is deleted. > as a result. However some comment info does not adapt to the change, which > I think is such a misguiding when reading related code. > > This patch fix this comment by moving trace/trace_events.h to TRACE_INCLUDE > (TRACE_INCLUDE_FILE), the macro TRACE_INCLUDE(TRACE_INCLUDE_FILE) is defined > in trace/define_trace.h > > Signed-off-by: Hou Pengyang > --- > include/trace/ftrace.h | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > index 41bf65f..cb78a8b 100644 > --- a/include/trace/ftrace.h > +++ b/include/trace/ftrace.h > @@ -1,7 +1,8 @@ > /* > * Stage 1 of the trace events. > * > - * Override the macros in to include the following: > + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to I agree that the comment needs updating, but not to this. TRACE_INCLUDE(TRACE_INCLUDE_FILE) is not very descriptive. Because nobody understand exactly what that is. Do you? Change it to: Override the macros in the event tracepoint header ... And do that for the ones below too. This is more descriptive than just describing what the code is literally doing. -- Steve > + * include the following: > * > * struct ftrace_raw_ { > * struct trace_entry ent; > @@ -170,7 +171,8 @@ > /* > * Stage 3 of the trace events. > * > - * Override the macros in to include the following: > + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to > + * include the following: > * > * enum print_line_t > * ftrace_raw_output_(struct trace_iterator *iter, int flags) > @@ -479,7 +481,8 @@ static inline notrace int ftrace_get_offsets_##call( \ > /* > * Stage 4 of the trace events. > * > - * Override the macros in to include the following: > + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to > + * include the following: > * > * For those macros defined with TRACE_EVENT: > *