From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753722AbbCBNWf (ORCPT ); Mon, 2 Mar 2015 08:22:35 -0500 Received: from 251.110.2.81.in-addr.arpa ([81.2.110.251]:33225 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751117AbbCBNWe (ORCPT ); Mon, 2 Mar 2015 08:22:34 -0500 Date: Mon, 2 Mar 2015 13:22:12 +0000 From: One Thousand Gnomes To: Jiri Slaby Cc: Dan Carpenter , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: potential corruption in synclink driver Message-ID: <20150302132212.339b0505@lxorguk.ukuu.org.uk> In-Reply-To: <54F0964F.6060503@suse.cz> References: <20141209085205.GA28655@mwanda> <54F0964F.6060503@suse.cz> Organization: Intel Corporation X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes and no :). In theory, the only line discipline which can handle > large chunks is hdlc. That one limits the count to 4096 by default. But > you are right, if someone sets maxframe in hdlc to the maximum value > (65535) and won't set maxframe of synclinc, they will have a buffer > overflow. > > These two guys are so old and ugly, maybe unused, so that I don't even They are still made, which puts them ahead of about 3/4 of the less maintained crap under drivers/ > know if they are worth fixing. In the normal case (no maxframe override > on commandline/module param), they should be safe. > > Maybe we can drop the support to override by parameters... Why do we care ? You have to be root to override the parameters anyway. If you can set those values you can already compromise the box anyway you feel fit. The problem is "if I am sufficiently expert to know about obscure config options, have the privilege to set them and screw up totally while using those privileges" The options are important for certain special case uses where you have > 4K frame sizes. A check on oversize frames might not be a bad idea but I don't think dropping it makes sense. Alan