From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754561AbbCBQgV (ORCPT ); Mon, 2 Mar 2015 11:36:21 -0500 Received: from mail-bl2on0145.outbound.protection.outlook.com ([65.55.169.145]:37824 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751690AbbCBQgU (ORCPT ); Mon, 2 Mar 2015 11:36:20 -0500 X-WSS-ID: 0NKLFGA-07-AEJ-02 X-M-MSG: Subject: [PATCH v2] x86: svm: use kvm_fast_pio_in() From: Joel Schopp To: Gleb Natapov , Paolo Bonzini , CC: David Kaplan , David Kaplan , , Joerg Roedel , , Borislav Petkov Date: Mon, 2 Mar 2015 10:40:04 -0600 Message-ID: <20150302164004.17276.77376.stgit@joelvmguard2.amd.com> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Joel.Schopp@amd.com; 8bytes.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(199003)(189002)(33646002)(19580395003)(83506001)(23676002)(575784001)(86362001)(19580405001)(87936001)(92566002)(47776003)(101416001)(77096005)(62966003)(77156002)(46102003)(229853001)(50986999)(105586002)(106466001)(50466002)(103116003)(54356999)(53416004)(71626003);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB474;H:atltwp01.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB474;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB314; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BY2PR02MB474;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB474; X-Forefront-PRVS: 0503FF9A3E X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2015 16:36:13.0222 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB474 X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Kaplan We can make the in instruction go faster the same way the out instruction is already. Changes from v1 * Added kvm_fast_pio_in() implementation that was left out of v1 Signed-off-by: David Kaplan [extracted from larger unlrelated patch, forward ported, tested] Signed-off-by: Joel Schopp --- arch/x86/include/asm/kvm_host.h | 1 + arch/x86/kvm/svm.c | 4 +++- arch/x86/kvm/x86.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 37 insertions(+), 1 deletion(-) diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h index a236e39..b976824 100644 --- a/arch/x86/include/asm/kvm_host.h +++ b/arch/x86/include/asm/kvm_host.h @@ -931,6 +931,7 @@ int kvm_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr); struct x86_emulate_ctxt; int kvm_fast_pio_out(struct kvm_vcpu *vcpu, int size, unsigned short port); +int kvm_fast_pio_in(struct kvm_vcpu *vcpu, int size, unsigned short port); void kvm_emulate_cpuid(struct kvm_vcpu *vcpu); int kvm_emulate_halt(struct kvm_vcpu *vcpu); int kvm_emulate_wbinvd(struct kvm_vcpu *vcpu); diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index d319e0c..f8c906b 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1899,7 +1899,7 @@ static int io_interception(struct vcpu_svm *svm) ++svm->vcpu.stat.io_exits; string = (io_info & SVM_IOIO_STR_MASK) != 0; in = (io_info & SVM_IOIO_TYPE_MASK) != 0; - if (string || in) + if (string) return emulate_instruction(vcpu, 0) == EMULATE_DONE; port = io_info >> 16; @@ -1907,6 +1907,8 @@ static int io_interception(struct vcpu_svm *svm) svm->next_rip = svm->vmcb->control.exit_info_2; skip_emulated_instruction(&svm->vcpu); + if (in) + return kvm_fast_pio_in(vcpu, size, port); return kvm_fast_pio_out(vcpu, size, port); } diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index bd7a70b..089247c 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -5463,6 +5463,39 @@ int kvm_fast_pio_out(struct kvm_vcpu *vcpu, int size, unsigned short port) } EXPORT_SYMBOL_GPL(kvm_fast_pio_out); +static int complete_fast_pio(struct kvm_vcpu *vcpu) +{ + u32 new_rax = kvm_register_read(vcpu, VCPU_REGS_RAX); + + if (!vcpu->arch.pio.count) + return 0; + if (vcpu->arch.pio.count * vcpu->arch.pio.size > 8) + return 0; + + memcpy(&new_rax, vcpu->arch.pio_data, + vcpu->arch.pio.count * vcpu->arch.pio.size); + kvm_register_write(vcpu, VCPU_REGS_RAX, new_rax); + + vcpu->arch.pio.count = 0; + return 1; +} + +int kvm_fast_pio_in(struct kvm_vcpu *vcpu, int size, unsigned short port) +{ + unsigned long val; + int ret = emulator_pio_in_emulated(&vcpu->arch.emulate_ctxt, size, + port, &val, 1); + + if (ret) { + kvm_register_write(vcpu, VCPU_REGS_RAX, val); + vcpu->arch.pio.count = 0; + } else + vcpu->arch.complete_userspace_io = complete_fast_pio; + + return ret; +} +EXPORT_SYMBOL_GPL(kvm_fast_pio_in); + static void tsc_bad(void *info) { __this_cpu_write(cpu_tsc_khz, 0);