From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983AbbCBRBY (ORCPT ); Mon, 2 Mar 2015 12:01:24 -0500 Received: from mail-qg0-f43.google.com ([209.85.192.43]:43744 "EHLO mail-qg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754057AbbCBRBU (ORCPT ); Mon, 2 Mar 2015 12:01:20 -0500 Date: Mon, 2 Mar 2015 12:01:16 -0500 From: Tejun Heo To: Rik van Riel Cc: Zefan Li , linux-kernel@vger.kernel.org, Peter Zijlstra , Clark Williams , Ingo Molnar , Luiz Capitulino , David Rientjes , Mike Galbraith , cgroups@vger.kernel.org Subject: Re: [PATCH v4 2/2] cpusets,isolcpus: add file to show isolated cpus in cpuset Message-ID: <20150302170116.GJ17694@htj.duckdns.org> References: <1424882288-2910-1-git-send-email-riel@redhat.com> <1424882288-2910-3-git-send-email-riel@redhat.com> <54EEFE15.3010005@huawei.com> <20150226121231.6fcba7e8@annuminas.surriel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150226121231.6fcba7e8@annuminas.surriel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 26, 2015 at 12:12:31PM -0500, Rik van Riel wrote: > On Thu, 26 Feb 2015 19:05:57 +0800 > Zefan Li wrote: > > > Make it return -ENOMEM ? Or make it a global variable and allocate memory for it > > in cpuset_init(). > > Here you are. This addresses your concern, as well as the > issue David Rientjes found earlier. > > ---8<--- > > Subject: cpusets,isolcpus: add file to show isolated cpus in cpuset > > The previous patch makes it so the code skips over isolcpus when > building scheduler load balancing domains. This makes it hard to > see for a user which of the CPUs in a cpuset are participating in > load balancing, and which ones are isolated cpus. > > Add a cpuset.isolcpus file with info on which cpus in a cpuset are > isolated CPUs. > > This file is read-only for now. In the future we could extend things > so isolcpus can be changed at run time, for the root (system wide) > cpuset only. > > Acked-by: David Rientjes > Cc: Peter Zijlstra > Cc: Clark Williams > Cc: Li Zefan > Cc: Ingo Molnar > Cc: Luiz Capitulino > Cc: David Rientjes > Cc: Mike Galbraith > Cc: cgroups@vger.kernel.org > Signed-off-by: Rik van Riel Applied 1-2 to cgroup/for-4.1. Thanks. -- tejun