From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932142AbbCBWTy (ORCPT ); Mon, 2 Mar 2015 17:19:54 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:37842 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754161AbbCBWTx (ORCPT ); Mon, 2 Mar 2015 17:19:53 -0500 Date: Mon, 2 Mar 2015 14:19:47 -0800 From: Dmitry Torokhov To: Jeff Epler Cc: linux-input@vger.kernel.org, Hans de Goede , Benjamin Tissoires , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: psmouse - when comparing PNP IDs ignore case Message-ID: <20150302221947.GA30717@dtor-glaptop> References: <20150228001852.GA18983@dtor-ws> <20150302221435.GA668@unpythonic.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150302221435.GA668@unpythonic.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jeff, On Mon, Mar 02, 2015 at 04:14:37PM -0600, Jeff Epler wrote: > On Fri, Feb 27, 2015 at 04:18:52PM -0800, Dmitry Torokhov wrote: > > PNP IDs are supposed to be case-insensitive and so we should compare > > them as such. > > Have specific systems popped up which need this fix, or is it just in > the interests of being correct? If there are specific system(s) that > are affected, it would be valuable to list them or at least say so. It is needed by another patch identifying SYN300D as a forcepad whereas in BIOS it is actually SYN300d. While we could change the kernel to match against SYN300d I am not sure if somebody else won't use SYN300D in some other BIOS. Thanks. -- Dmitry