From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754421AbbCCEFR (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 Mar 2015 23:05:17 -0500
Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.230]:38825 "EHLO
	cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751941AbbCCEFP (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 Mar 2015 23:05:15 -0500
Date: Mon, 2 Mar 2015 23:06:09 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Hou Pengyang <houpengyang@huawei.com>
Cc: <mingo@redhat.com>, <wangnan0@huawei.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: Fix comments about trace/ftrace.h
Message-ID: <20150302230609.7a9670c9@grimm.local.home>
In-Reply-To: <54F51E9B.7020807@huawei.com>
References: <1425306534-161763-1-git-send-email-houpengyang@huawei.com>
	<20150302091044.0039be5e@gandalf.local.home>
	<54F51E9B.7020807@huawei.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-RR-Connecting-IP: 107.14.168.118:25
X-Cloudmark-Score: 0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 3 Mar 2015 10:38:19 +0800
Hou Pengyang <houpengyang@huawei.com> wrote:


> >> --- a/include/trace/ftrace.h
> >> +++ b/include/trace/ftrace.h
> >> @@ -1,7 +1,8 @@
> >>   /*
> >>    * Stage 1 of the trace events.
> >>    *
> >> - * Override the macros in <trace/trace_events.h> to include the following:
> >> + * Override the macros in TRACE_INCLUDE(TRACE_INCLUDE_FILE) to
> >
> > I agree that the comment needs updating, but not to this.
> > TRACE_INCLUDE(TRACE_INCLUDE_FILE) is not very descriptive. Because
> > nobody understand exactly what that is. Do you?
> >
> > Change it to:
> >
> >    Override the macros in the event tracepoint header ...
> >
> > And do that for the ones below too. This is more descriptive than just
> > describing what the code is literally doing.
> >
> > -- Steve
> >
> To be more descriptive, how about "Override the macros in the event 
> tracepoint header <trace/events/XXX.h> ..." ? since, tracepoint headers 
> have already been moved to trace/events/ .

That's fine with me too.


-- Steve