From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754858AbbCBX7T (ORCPT ); Mon, 2 Mar 2015 18:59:19 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:19910 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754634AbbCBX7Q (ORCPT ); Mon, 2 Mar 2015 18:59:16 -0500 X-AuditID: cbfee68d-f79296d000004278-1b-54f4f952237f Date: Tue, 03 Mar 2015 08:58:09 +0900 From: Changman Lee To: Chao Yu Cc: Jaegeuk Kim , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix to issue small discard in real-time mode discard Message-id: <20150302235809.GA6541@lcm-devel.org> References: <019801d05338$52aae5b0$f800b110$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <019801d05338$52aae5b0$f800b110$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42JZI2LSohv080uIwZ0X2hb/mz6yWTxZP4vZ 4tIid4vLu+awObB4bFrVyeaxe8FnJo++LasYPT5vkgtgieKySUnNySxLLdK3S+DKmN9/iK2g nbPi5uV7TA2MS9m7GDk5JARMJJoOrGeFsMUkLtxbz9bFyMUhJLCUUeL/331wRT0LD7BDJBYx Smx7PJURwvnJKDH5/TtGkCoWAVWJhzPWMIPYbAJaEu2n17KA2CICShK/5i8CWsHBwSyQI7Gn IRckLCzgL3GgcxLYAl4BQ4kdy5+zg5QICVhK/O4PgQgLSvyYfA9sCjPQxPU7jzNB2NISj/7O AGvlFLCS6Ps9H2yrqICKxJST28AekBBYxy5xfN5LVojTBCS+TT7EAjJfQkBWYtMBZoi/JCUO rrjBMoFRbBaSdbOQrJuFZN0CRuZVjKKpBckFxUnpRYZ6xYm5xaV56XrJ+bmbGIGxdPrfs94d jLcPWB9iFOBgVOLh9ZjzOUSINbGsuDL3EKMp0BUTmaVEk/OBEZtXEm9obGZkYWpiamxkbmmm JM6rKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAPjA5lmhszUdxyHGkof2axqmLI55K/y 24rXDwIvMy2qm8DQIm6k8q36huKTdT2nXQOWz/IUaJNacOCVpUkXu97v/b2Ki+RbDbZXLYlj PlRwV+KFMffmaPFS5trvLzUarvvG+WoY6OhsCuAo73LZdWfqw0rX2IVXPwVv11eQErLe2ybb FHXvob8SS3FGoqEWc1FxIgBFRgycoAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jAd2gn19CDHZM1rD43/SRzeLJ+lnM FpcWuVtc3jWHzYHFY9OqTjaP3Qs+M3n0bVnF6PF5k1wAS1QDo01GamJKapFCal5yfkpmXrqt kndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0EolhbLEnFKgUEBicbGSvh2mCaEhbroW MI0Rur4hQXA9RgZoIGEdY8b8/kNsBe2cFTcv32NqYFzK3sXIySEhYCLRs/AAlC0mceHeerYu Ri4OIYFFjBLbHk9lhHB+MkpMfv+OEaSKRUBV4uGMNcwgNpuAlkT76bUsILaIgJLEr/mLWLsY OTiYBXIk9jTkgoSFBfwlDnROAlvAK2AosWP5c3aQEiEBS4nf/SEQYUGJH5PvgU1hBpq4fudx JghbWuLR3xlgrZwCVhJ9v+eDbRUVUJGYcnIb2wRGgVlI2mchaZ+FpH0BI/MqRtHUguSC4qT0 XEO94sTc4tK8dL3k/NxNjOBIfSa1g3Flg8UhRgEORiUeXs3ELyFCrIllxZW5hxglOJiVRHgF 3gGFeFMSK6tSi/Lji0pzUosPMZoCw2Iis5Rocj4wieSVxBsam5gZWRqZWRiZmJsrifMq2beF CAmkJ5akZqemFqQWwfQxcXBKNTC2sK6PYvPsKr7gGD6x9S+XX/R3/4crZY5dvvhZdYLOqsh/ 7CHzXx0OeXbqQ37D50KNKW+vz3GR3mdb0jR99zE9AS6ddTVJi1kDNAtnZqYnnHNZZLv+783v +6y35lz2rTzzOtt18wmRb2Ie9p9PnE2LqPjau/pVp4lVO2tlZo9teNSK1dNfvUtVYinOSDTU Yi4qTgQAw7N0ReoCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 28, 2015 at 05:23:30PM +0800, Chao Yu wrote: > Now in f2fs, we share functions and structures for batch mode and real-time mode > discard. For real-time mode discard, in shared function add_discard_addrs, we > will use uninitialized trim_minlen in struct cp_control to compare with length > of contiguous free blocks to decide whether skipping discard fragmented freespace > or not, this makes us ignore small discard sometimes. Fix it. > > Signed-off-by: Chao Yu > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index daee4ab..fcc1cc2 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -549,7 +549,7 @@ static void add_discard_addrs(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > end = __find_rev_next_zero_bit(dmap, max_blocks, start + 1); > > - if (end - start < cpc->trim_minlen) > + if (force && end - start < cpc->trim_minlen) > continue; Reviewed-by : Changman Lee > > __add_discard_entry(sbi, cpc, start, end); > -- > 2.3.1 >