From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756997AbbCCT2D (ORCPT ); Tue, 3 Mar 2015 14:28:03 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36550 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756808AbbCCT2A (ORCPT ); Tue, 3 Mar 2015 14:28:00 -0500 Date: Tue, 03 Mar 2015 14:27:58 -0500 (EST) Message-Id: <20150303.142758.822602589629075339.davem@davemloft.net> To: joe@perches.com Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code From: David Miller In-Reply-To: <1425409671.17273.42.camel@perches.com> References: <1425407104.17273.27.camel@perches.com> <1425408125.5130.191.camel@edumazet-glaptop2.roam.corp.google.com> <1425409671.17273.42.camel@perches.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2015 11:28:00 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Tue, 03 Mar 2015 11:07:51 -0800 > On Tue, 2015-03-03 at 10:42 -0800, Eric Dumazet wrote: >> On Tue, 2015-03-03 at 10:25 -0800, Joe Perches wrote: >> >> > At least for arm gcc 4.6.3, it emits different code >> > for net/l2tp/l2tp_eth.o >> >> Then it looks like arm gcc or arm linux memset() should be improved. > > Perhaps you can take that up with the gcc folk. > > I think it appropriate to improve the actual emitted > code for the compiler I use. In the long term, this is poor time spent. If you fixed GCC everyone would benefit in the world, not just kernel builders. Furthermore, none of this crap is in the fast path of anything. I'm not applying this series, it's basis is not well founded yet you keep trying to argue otherwise.