From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757136AbbCCThw (ORCPT ); Tue, 3 Mar 2015 14:37:52 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36697 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754190AbbCCThv (ORCPT ); Tue, 3 Mar 2015 14:37:51 -0500 Date: Tue, 03 Mar 2015 14:37:48 -0500 (EST) Message-Id: <20150303.143748.2255336109763734319.davem@davemloft.net> To: linux@roeck-us.net Cc: netdev@vger.kernel.org, claudiu.manoil@freescale.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gianfar: Reduce logging noise seen due to phy polling if link is down From: David Miller In-Reply-To: <1425326607-21464-1-git-send-email-linux@roeck-us.net> References: <1425326607-21464-1-git-send-email-linux@roeck-us.net> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2015 11:37:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Guenter Roeck Date: Mon, 2 Mar 2015 12:03:27 -0800 > Commit 6ce29b0e2a04 ("gianfar: Avoid unnecessary reg accesses in adjust_link()") > eliminates unnecessary calls to adjust_link for phy devices which don't support > interrupts and need polling. As part of that work, the 'new_state' local flag, > which was used to reduce logging noise on the console, was eliminated. > > Unfortunately, that means that a 'Link is Down' log message will now be > issued continuously if a link is configured as UP, the link state is down, > and the associated phy requires polling. This occurs because priv->oldduplex > is -1 in this case, which always differs from phydev->duplex. In addition, > phydev->speed may also differ from priv->oldspeed. gfar_update_link_state() > is therefore called each time a phy is polled, even if the link state did not > change. > > Cc: Claudiu Manoil > Signed-off-by: Guenter Roeck Applied, thanks.