From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756621AbbCCT6U (ORCPT ); Tue, 3 Mar 2015 14:58:20 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36880 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755752AbbCCT6R (ORCPT ); Tue, 3 Mar 2015 14:58:17 -0500 Date: Tue, 03 Mar 2015 14:58:15 -0500 (EST) Message-Id: <20150303.145815.1129211297511474723.davem@davemloft.net> To: joe@perches.com Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 01/14] etherdevice: Add eth__addr CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS code From: David Miller In-Reply-To: <1425411669.17273.52.camel@perches.com> References: <1425409671.17273.42.camel@perches.com> <20150303.142758.822602589629075339.davem@davemloft.net> <1425411669.17273.52.camel@perches.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2015 11:58:17 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Perches Date: Tue, 03 Mar 2015 11:41:09 -0800 > Until such time as the linux crosstools compilers are updated, > (they seem stuck on 4.6.3 from 3 years ago) > https://www.kernel.org/pub/tools/crosstool/ > I think the series is a trivial, small improvement. You are even admitting that even for your specific case you are using 3+ year old compiler technology. These are slow paths, so correctness is the most important aspect. Converting these locations to consistently use eth_*() is fine, but then "optimizing" a 6 by memset for configuration paths when the compiler should be more than capable of doing this just fine is not convincing at all to me.