From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757122AbbCCUCM (ORCPT ); Tue, 3 Mar 2015 15:02:12 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36917 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755594AbbCCUCK (ORCPT ); Tue, 3 Mar 2015 15:02:10 -0500 Date: Tue, 03 Mar 2015 15:02:07 -0500 (EST) Message-Id: <20150303.150207.742456888724586407.davem@davemloft.net> To: rdunlap@infradead.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux.nics@intel.com, jeffrey.t.kirsher@intel.com Subject: Re: [PATCH -next] net: i40e: fix build, depends on CONFIGFS_FS From: David Miller In-Reply-To: <54F60D0A.6020903@infradead.org> References: <54F60D0A.6020903@infradead.org> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Tue, 03 Mar 2015 12:02:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Date: Tue, 03 Mar 2015 11:35:38 -0800 > From: Randy Dunlap > > i40e uses configfs interfaces so it should depend on CONFIGFS_FS. > > Fixes these build errors: > > drivers/built-in.o: In function `i40e_cfgfs_group_make_item': > i40e_configfs.c:(.text+0x2fcdca): undefined reference to `config_item_init_type_name' > drivers/built-in.o: In function `i40e_configfs_init': > (.text+0x2fcee6): undefined reference to `config_group_init' > drivers/built-in.o: In function `i40e_configfs_init': > (.text+0x2fcf0c): undefined reference to `configfs_register_subsystem' > drivers/built-in.o: In function `i40e_configfs_exit': > (.text+0x2fcf71): undefined reference to `configfs_unregister_subsystem' > > Signed-off-by: Randy Dunlap Intel guys, I am furiously mad. I've told you guys a thousand times to use portable, reasonable mechanisms to configure your hardware. Using facilities that can be used for other cards from other vendors with similar facilities. If such portable netdevice configuration frameworks do not exist, create it. Every time you make a device specific mechanism for configuration, a small kitten dies somewhere in the world. Please remove all of this configfs crap for twiddling bandwidth et al. knobs, before I do it for you. Thanks.