From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561AbbCCJJl (ORCPT ); Tue, 3 Mar 2015 04:09:41 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:33570 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752901AbbCCJJi (ORCPT ); Tue, 3 Mar 2015 04:09:38 -0500 Date: Tue, 3 Mar 2015 09:09:29 +0000 From: Mark Brown To: Takashi Iwai Cc: linux-kernel@vger.kernel.org Message-ID: <20150303090929.GG21293@sirena.org.uk> References: <20150302182418.GD21293@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="K3V7sZWrS7YKVA8w" Content-Disposition: inline In-Reply-To: X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: regcache_sync() errors for read-only registers cache X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --K3V7sZWrS7YKVA8w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 02, 2015 at 08:15:23PM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > Please don't bury patches in the middle of mails, that just means that > > if the patch is useful it's painful to apply. > The --scissors option of git am is your friend. That's still pain. > > Your patch seems fine but > > can you please resend in a directly applyable format unless something in > > the below indicates against that... > Hm, so do you think that my patch is the best way to fix? I wasn't > sure about it, that's why I wrote in that style. Well, it's either that or adding the values read back from the chip to the defaults. > > > Also, _regmap_write() itself calls again regmap_writeable(), so it's > > > superfluous. Alternatively, we may check -EIO from _regmap_write() > > > and treat as a special case not to show the error. Or, add a > > > parameter to skip regmap_writeable() call. > > I'm sorry but I can't parse the above - what is "it" in this context? > regmap_wrietable() call in _regmap_write(). It's superfluous with respect to what? Still a bit confused, sorry. > > Silently ignoring -EIO from the physical register write sounds like a > > very bad idea though, that seems likely to discard actual errors. > Right, in that case, a special error code might be used. But this > sounds like an overkill, too. It also sounds like it's heading towards the complex and fragile. --K3V7sZWrS7YKVA8w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU9XpIAAoJECTWi3JdVIfQbnYIAINpagTcreQ0KAu2NARVhCvs clXG9Hb5Fc8CuQAkcCC5iyTxNyN0sa8gp475wMq8XTVX0qevOpHpd0LNgW7OlD5t +tIN8N+8ioYdiXDow4qIUPy0DNEwxvSJjGZKRKdw0eOU+xHatvDWEIyOdpSNMsbh QuBZKd1Mvp4zu49j5xe4APZg9eAAQEwRCRxENwLzvXLYaKi/5X+Rj7zc9dWTnbHK +4gE1sqXnVNs4wuHIlhjjCdqg/Z3BpvoBcuin8EAiKiTHHddC+XLeWDqjuZCd0Uo IZJvFuJkgPmm+NDAjVtpzLOOYa46JAoD+i6r/54ays/bvG1iNllKMD6M11OkP2o= =u/aq -----END PGP SIGNATURE----- --K3V7sZWrS7YKVA8w--