From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756112AbbCCKNT (ORCPT ); Tue, 3 Mar 2015 05:13:19 -0500 Received: from smtp.citrix.com ([66.165.176.89]:9369 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754835AbbCCKNR (ORCPT ); Tue, 3 Mar 2015 05:13:17 -0500 X-IronPort-AV: E=Sophos;i="5.09,681,1418083200"; d="scan'208";a="239318516" Date: Tue, 3 Mar 2015 10:13:14 +0000 From: Wei Liu To: Joe Perches CC: , Ian Campbell , Wei Liu , , Subject: Re: [PATCH net-next 06/14] xen: Use eth__addr instead of memset Message-ID: <20150303101314.GV11855@zion.uk.xensource.com> References: <8762529463d8d2290ef0b67e5ed91f4bccb98b37.1425354528.git.joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <8762529463d8d2290ef0b67e5ed91f4bccb98b37.1425354528.git.joe@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 02, 2015 at 07:54:51PM -0800, Joe Perches wrote: > Use the built-in function instead of memset. > > Signed-off-by: Joe Perches Acked-by: Wei Liu > --- > drivers/net/xen-netback/interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index f38227a..4ae98e2 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -438,7 +438,7 @@ struct xenvif *xenvif_alloc(struct device *parent, domid_t domid, > * stolen by an Ethernet bridge for STP purposes. > * (FE:FF:FF:FF:FF:FF) > */ > - memset(dev->dev_addr, 0xFF, ETH_ALEN); > + eth_broadcast_addr(dev->dev_addr); > dev->dev_addr[0] &= ~0x01; > > netif_carrier_off(dev); > -- > 2.1.2