From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932370AbbCCQnT (ORCPT ); Tue, 3 Mar 2015 11:43:19 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:39716 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756819AbbCCQnN (ORCPT ); Tue, 3 Mar 2015 11:43:13 -0500 Date: Tue, 3 Mar 2015 08:43:14 -0800 From: Darren Hart To: Krzysztof Kozlowski Cc: Cezary Jackiewicz , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Guenter Roeck , Matthew Garrett , stable@vger.kernel.org Subject: Re: [RFT PATCH v3 2/2] compal-laptop: Check return value of power_supply_register Message-ID: <20150303164314.GB83894@vmdeb7> References: <1424438015-3006-1-git-send-email-k.kozlowski@samsung.com> <1424438015-3006-2-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1424438015-3006-2-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 20, 2015 at 02:13:35PM +0100, Krzysztof Kozlowski wrote: > The return value of power_supply_register() call was not checked and > even on error probe() function returned 0. If registering failed then > during unbind the driver tried to unregister power supply which was not > actually registered. > > This could lead to memory corruption because power_supply_unregister() > unconditionally cleans up given power supply. > > Fix this by checking return status of power_supply_register() call. In > case of failure, clean up sysfs entries and fail the probe. > > Signed-off-by: Krzysztof Kozlowski > Fixes: 9be0fcb5ed46 ("compal-laptop: add JHL90, battery & hwmon interface") > Cc: Acked-by: Darren Hart -- Darren Hart Intel Open Source Technology Center