From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757508AbbCCR43 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 Mar 2015 12:56:29 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50992 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932666AbbCCR4J (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 Mar 2015 12:56:09 -0500
Date: Tue, 3 Mar 2015 18:55:31 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: David Ahern <david.ahern@oracle.com>
Cc: Jiri Olsa <jolsa@kernel.org>, linux-kernel@vger.kernel.org,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        Ingo Molnar <mingo@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 12/14] tools build: Allow to override feature checks setup
Message-ID: <20150303175531.GD27424@krava.brq.redhat.com>
References: <1425392797-22572-1-git-send-email-jolsa@kernel.org>
 <1425392797-22572-13-git-send-email-jolsa@kernel.org>
 <54F5F414.2070608@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54F5F414.2070608@oracle.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 03, 2015 at 10:49:08AM -0700, David Ahern wrote:
> On 3/3/15 7:26 AM, Jiri Olsa wrote:
> >Allowing to override configuration variables for feature
> >checks. Also adding automated test and documentation.
> 
> Rather than an 'override' why not require users to specify feature checks of
> interest? ie., the previous patch moved all of perf's feature checks to a
> common Makefile. Why not have perf specify features of interest to it
> instead?

well, thats what they can do as you can see in the example:

+  FEATURE_TESTS   := glibc backtrace
+  FEATURE_DISPLAY := glibc
+
+  srctree := ../../../..
+  include $(srctree)/tools/build/Makefile.feature

you specify features you want to check in FEATURE_TESTS variable
and features status you want to display in FEATURE_DISPLAY variable

at the mean time the default settings for those 2 is what
perf uses now (perf is the only user)

in future when there's multiple users, perf will set those
variables as well..

jirka