From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756948AbbCCSxC (ORCPT ); Tue, 3 Mar 2015 13:53:02 -0500 Received: from mail-qg0-f48.google.com ([209.85.192.48]:36941 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755413AbbCCSxA (ORCPT ); Tue, 3 Mar 2015 13:53:00 -0500 Date: Tue, 3 Mar 2015 12:52:48 -0600 From: Drew Fustini To: Sudip Mukherjee Cc: Thomas Petazzoni , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: fbtft: move externs to header file Message-ID: <20150303185248.GA15060@mediagoblin.asciipr0n.com> References: <20150303101917.GA20306@lappy486> <20150303110301.GA2228@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150303110301.GA2228@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 03, 2015 at 04:33:01PM +0530, Sudip Mukherjee wrote: > but now it adds 6 additional warning in checkpatch --strict > "extern prototypes should be avoided in .h files" Thanks, Sudip. I did not realize that was an option for checkpatch. I see now that there are additional warnings as you mentioned: CHECK: extern prototypes should be avoided in .h files CHECK: Alignment should match open parenthesis CHECK: Please don't use multiple blank lines Drew