From: David Miller <davem@davemloft.net>
To: Alexey.Brodkin@synopsys.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vineet.Gupta1@synopsys.com, andriy.shevchenko@linux.intel.com,
peppe.cavallaro@st.com, sonic.zhang@analog.com
Subject: Re: [PATCH] stmmac: check IRQ availability early on probe
Date: Wed, 04 Mar 2015 15:44:12 -0500 (EST) [thread overview]
Message-ID: <20150304.154412.1886796464281085513.davem@davemloft.net> (raw)
In-Reply-To: <1425379604-24107-1-git-send-email-abrodkin@synopsys.com>
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Date: Tue, 3 Mar 2015 13:46:44 +0300
> Currently we're getting IRQs after lots of resources are already
> allocated:
> * netdev
> * clocks
> * MDIO bus
> Also HW gets initialized by the time when checking IRQs as well.
>
> Now there's a possibility for master interrupt controller to be not
> probed yet. This will lead to exit from GMAC probe routine with "-
> EPROBE_DEFER" and so deferred probe will hapen later on.
>
> But since we exited the first GMAC probe without release of all
> allocated resources there could be conflicts on subsequent probes.
>
> For example this is what happens for me:
...
> Essential fix is to check for IRQs availability as early as possible and
> then safely go to deferred probe if IRQs are not there yet.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Applied, thanks.
prev parent reply other threads:[~2015-03-04 20:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 10:46 Alexey Brodkin
2015-03-04 20:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304.154412.1886796464281085513.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=sonic.zhang@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®