From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751338AbbCDUpZ (ORCPT ); Wed, 4 Mar 2015 15:45:25 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:49374 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbCDUpX (ORCPT ); Wed, 4 Mar 2015 15:45:23 -0500 Date: Wed, 04 Mar 2015 15:45:22 -0500 (EST) Message-Id: <20150304.154522.665232561815766240.davem@davemloft.net> To: nschichan@freebox.fr Cc: tklauser@distanz.ch, balbi@ti.com, w-lkml@lebenslange-mailadresse.de, ebiederm@xmission.com, alexander.h.duyck@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bcm63xx_enet: fix poll callback. From: David Miller In-Reply-To: <1425383112-23851-1-git-send-email-nschichan@freebox.fr> References: <1425383112-23851-1-git-send-email-nschichan@freebox.fr> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Mar 2015 12:45:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicolas Schichan Date: Tue, 3 Mar 2015 12:45:12 +0100 > In case there was some tx buffer reclaimed and not enough rx packets > to consume the whole budget, napi_complete would not be called and > interrupts would be kept disabled, effectively resulting in the > network core never to call the poll callback again and no rx/tx > interrupts to be fired either. > > Fix that by only accounting the rx work done in the poll callback. > > Signed-off-by: Nicolas Schichan Applied.