From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933705AbbCDQUU (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 11:20:20 -0500
Received: from smtprelay0220.hostedemail.com ([216.40.44.220]:57425 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S932452AbbCDQUQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 11:20:16 -0500
X-Session-Marker: 6E657665747340676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2194:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3870:3871:3872:4321:5007:6261:6742:7875:7974:10004:10400:10848:10967:11232:11658:11914:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: pump20_1db53596df5f
X-Filterd-Recvd-Size: 2366
Date: Wed, 4 Mar 2015 11:20:10 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Joe Perches <joe@perches.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Russell King <linux@arm.linux.org.uk>,
        Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, patches@linaro.org,
        linaro-kernel@lists.linaro.org, Sumit Semwal <sumit.semwal@linaro.org>,
        Dirk Behme <dirk.behme@de.bosch.com>,
        Daniel Drake <drake@endlessm.com>,
        Dmitry Pervushin <dpervushin@gmail.com>,
        Tim Sander <tim@krieglstein.org>
Subject: Re: [PATCH 4.0-rc1 v17 4/6] printk: Simple implementation for NMI
 backtracing
Message-ID: <20150304112010.338501ab@gandalf.local.home>
In-Reply-To: <1425485601.2712.9.camel@perches.com>
References: <1422022952-31552-1-git-send-email-daniel.thompson@linaro.org>
	<1425463974-23568-1-git-send-email-daniel.thompson@linaro.org>
	<1425463974-23568-5-git-send-email-daniel.thompson@linaro.org>
	<1425485601.2712.9.camel@perches.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 04 Mar 2015 08:13:21 -0800
Joe Perches <joe@perches.com> wrote:

> On Wed, 2015-03-04 at 10:12 +0000, Daniel Thompson wrote:
> > Currently there is a quite a pile of code sitting in
> > arch/x86/kernel/apic/hw_nmi.c to support safe all-cpu backtracing from NMI.
> > The code is inaccessible to backtrace implementations for other
> > architectures, which is a shame because they would probably like to be
> > safe too.
> > 
> > Copy this code into printk. We'll port the x86 NMI backtrace to it in a
> > later patch.
> 
> I think this would be better as a separate file
> rather than increasing the bulk of printk.c
> 

I agree, as printk already has its own directory. Perhaps a
"nmi_backtrace.c"?

-- Steve