From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759400AbbCDSjr (ORCPT ); Wed, 4 Mar 2015 13:39:47 -0500 Received: from mail-by2on0116.outbound.protection.outlook.com ([207.46.100.116]:21267 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759022AbbCDSjp (ORCPT ); Wed, 4 Mar 2015 13:39:45 -0500 X-Greylist: delayed 84869 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 Mar 2015 13:39:45 EST Date: Wed, 4 Mar 2015 12:34:19 -0600 From: Kim Phillips To: Cristian Stoica CC: yjin , , , , , , , , Subject: Re: [PATCH 1/3] crypto: caam: fix some compile warnings Message-ID: <20150304123419.7baecac7320d5b3483449dab@freescale.com> In-Reply-To: <54F6CA60.5030905@freescale.com> References: <1425365453-19358-1-git-send-email-yanjiang.jin@windriver.com> <1425365453-19358-2-git-send-email-yanjiang.jin@windriver.com> <20150303125953.8585904680288a9734566b42@freescale.com> <54F66EA3.7080506@windriver.com> <54F6909D.8040002@windriver.com> <54F6CA60.5030905@freescale.com> Organization: Freescale Semiconductor, Inc. X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.13; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 Authentication-Results: spf=temperror (sender IP is 192.88.158.2) smtp.mailfrom=kim.phillips@freescale.com; gmail.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:192.88.158.2;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(24454002)(479174004)(377454003)(51704005)(199003)(189002)(46406003)(23726002)(92566002)(36756003)(93886004)(106466001)(62966003)(47776003)(110136001)(77156002)(19580395003)(87936001)(100306002)(33646002)(6806004)(19580405001)(104016003)(50986999)(77096005)(2950100001)(50226001)(46102003)(76176999)(86362001)(50466002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0301MB1281;H:az84smr01.freescale.net;FPR:;SPF:TempError;MLV:sfv;A:1;MX:3;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1281;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1186; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006);SRVR:BN3PR0301MB1281;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0301MB1281; X-Forefront-PRVS: 0505147DDB X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2015 18:39:39.5976 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.158.2] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1281 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Mar 2015 11:03:28 +0200 Cristian Stoica wrote: > On 03/04/2015 06:57 AM, yjin wrote: > > An alternative is moving the definitions to a ".c" file, but I don't > > think it will be fundamental different. > > I know I am fixing a potential error which doesn't exist now, it seems > > useless for the current upstream version, we can abandon my patch. But I > > still think the current implementation adds unnecessary restrictions for > > its users. > > I think that both dma_map_sg_chained and dma_unmap_sg_chained should go > away. They were added to support chained scatterlists, but as far as I > verified, dma_map_sg should handle that case as well. > > Kim, can you confirm this? I don't see how, e.g., for one, dma_map_sg is I/O TLB implementation-dependent. Kim