From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753369AbbCDWNI (ORCPT ); Wed, 4 Mar 2015 17:13:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33409 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753347AbbCDWNG (ORCPT ); Wed, 4 Mar 2015 17:13:06 -0500 Date: Wed, 4 Mar 2015 14:13:05 -0800 From: Andrew Morton To: Sergey Senozhatsky Cc: Minchan Kim , Nitin Gupta , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 2/2] zram: introduce automatic device_id generation Message-Id: <20150304141305.06bc7cc7bdb0d8233d9aae97@linux-foundation.org> In-Reply-To: <1425478601-19141-3-git-send-email-sergey.senozhatsky@gmail.com> References: <1425478601-19141-1-git-send-email-sergey.senozhatsky@gmail.com> <1425478601-19141-3-git-send-email-sergey.senozhatsky@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Mar 2015 23:16:41 +0900 Sergey Senozhatsky wrote: > +static ssize_t zram_add_show(struct class *class, > + struct class_attribute *attr, > + char *buf) > +{ > + int ret; > + > + mutex_lock(&zram_index_mutex); > + /* read operation on zram_add is - pick up device_id > + * automatically, add corresponding device and return > + * that device_id back to user */ > + ret = zram_add(-1); > + mutex_unlock(&zram_index_mutex); > + > + if (ret < 0) > + return ret; > + return scnprintf(buf, PAGE_SIZE, "%d\n", ret); > +} Please don't invent new commenting styles. Because doing so inevitably creates a mixed-up mess, which is what we now have. --- a/drivers/block/zram/zram_drv.c~zram-introduce-automatic-device_id-generation-fix +++ a/drivers/block/zram/zram_drv.c @@ -1281,9 +1281,10 @@ static ssize_t zram_add_show(struct clas int ret; mutex_lock(&zram_index_mutex); - /* read operation on zram_add is - pick up device_id - * automatically, add corresponding device and return - * that device_id back to user */ + /* + * read operation on zram_add is - pick up device_id automatically, add + * corresponding device and return that device_id back to user + */ ret = zram_add(-1); mutex_unlock(&zram_index_mutex); _