From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932854AbbCDPs4 (ORCPT ); Wed, 4 Mar 2015 10:48:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932486AbbCDPsz (ORCPT ); Wed, 4 Mar 2015 10:48:55 -0500 Date: Wed, 4 Mar 2015 23:48:34 +0800 From: Baoquan He To: Yinghai Lu Cc: "H. Peter Anvin" , Kees Cook , Vivek Goyal , Andy Lutomirski , Andrew Morton , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List Subject: Re: [PATCH v2 1/9] remove a unused function parameter Message-ID: <20150304154834.GA2102@dhcp-17-102.nay.redhat.com> References: <1425308310-2318-1-git-send-email-bhe@redhat.com> <1425308310-2318-2-git-send-email-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/03/15 at 10:32am, Yinghai Lu wrote: > On Mon, Mar 2, 2015 at 6:58 AM, Baoquan He wrote: > > static void mem_avoid_init(unsigned long input, unsigned long input_size, > > - unsigned long output, unsigned long output_size) > > + unsigned long output_size) > > { > > u64 initrd_start, initrd_size; > > u64 cmd_line, cmd_line_size; > > @@ -349,7 +349,7 @@ unsigned char *choose_kernel_location(struct boot_params *params, > > > > /* Record the various known unsafe memory ranges. */ > > mem_avoid_init((unsigned long)input, input_size, > > - (unsigned long)output, output_size); > > + output_size); > > > > /* Walk e820 and find a random address. */ > > random = find_random_addr(choice, output_size); > > No, that is not right, but it is not your fault. > > let me sort it out. All right, I saw your posting to address related issue, will take it out from next repost. Thanks Baoquan