From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753764AbbCEA4O (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 Mar 2015 19:56:14 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:34829 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753075AbbCEA4L (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 Mar 2015 19:56:11 -0500
Date: Wed, 4 Mar 2015 16:56:10 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Minchan Kim <minchan@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Juneho Choi <juno.choi@lge.com>, Gunho Lee <gunho.lee@lge.com>,
        Luigi Semenzato <semenzato@google.com>,
        Dan Streetman <ddstreet@ieee.org>,
        Seth Jennings <sjennings@variantweb.net>,
        Nitin Gupta <ngupta@vflare.org>, Jerome Marchand <jmarchan@redhat.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, opensource.ganesh@gmail.com
Subject: Re: [PATCH v2 7/7] zsmalloc: add fullness into stat
Message-Id: <20150304165610.5befcdbf2573c66509e77b55@linux-foundation.org>
In-Reply-To: <20150305004330.GB2592@blaptop>
References: <1425445292-29061-1-git-send-email-minchan@kernel.org>
	<1425445292-29061-8-git-send-email-minchan@kernel.org>
	<20150304140202.905f566b7107e2735d075b27@linux-foundation.org>
	<20150305004330.GB2592@blaptop>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 5 Mar 2015 09:43:31 +0900 Minchan Kim <minchan@kernel.org> wrote:

> Hello Andrew,
> 
> On Wed, Mar 04, 2015 at 02:02:02PM -0800, Andrew Morton wrote:
> > On Wed,  4 Mar 2015 14:01:32 +0900 Minchan Kim <minchan@kernel.org> wrote:
> > 
> > > +static int zs_stats_size_show(struct seq_file *s, void *v)
> > > +{
> > > +	int i;
> > > +	struct zs_pool *pool = s->private;
> > > +	struct size_class *class;
> > > +	int objs_per_zspage;
> > > +	unsigned long class_almost_full, class_almost_empty;
> > > +	unsigned long obj_allocated, obj_used, pages_used;
> > > +	unsigned long total_class_almost_full = 0, total_class_almost_empty = 0;
> > > +	unsigned long total_objs = 0, total_used_objs = 0, total_pages = 0;
> > > +
> > > +	seq_printf(s, " %5s %5s %11s %12s %13s %10s %10s %16s\n",
> > > +			"class", "size", "almost_full", "almost_empty",
> > > +			"obj_allocated", "obj_used", "pages_used",
> > > +			"pages_per_zspage");
> > 
> > Documentation?
> 
> It should been since [0f050d9, mm/zsmalloc: add statistics support].
> Anyway, I will try it.
> Where is right place to put only this statistics in Documentation?
> 
> Documentation/zsmalloc.txt?
> Documentation/vm/zsmalloc.txt?
> Documentation/blockdev/zram.txt?
> Documentation/ABI/testing/sysfs-block-zram?

hm, this is debugfs so Documentation/ABI/testing/sysfs-block-zram isn't
the right place.

akpm3:/usr/src/25> grep -rli zsmalloc Documentation 
akpm3:/usr/src/25> 

lol.

Documentation/vm/zsmalloc.txt looks good.