From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932974AbbCDUeV (ORCPT ); Wed, 4 Mar 2015 15:34:21 -0500 Received: from mga03.intel.com ([134.134.136.65]:29844 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932907AbbCDUeU (ORCPT ); Wed, 4 Mar 2015 15:34:20 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,689,1418112000"; d="scan'208";a="660510702" Date: Thu, 5 Mar 2015 04:34:02 +0800 From: kbuild test robot To: Javi Merino Cc: kbuild-all@01.org, Eduardo Valentin , Kapileshwar Singh , Punit Agrawal , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] thermal: cpu_cooling: fix ptr_ret.cocci warnings Message-ID: <20150304203402.GA168719@athens.lkp.intel.com> References: <201503050401.EJ55ouQ7%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201503050401.EJ55ouQ7%fengguang.wu@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/thermal/cpu_cooling.c:463:18-24: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci CC: Javi Merino Signed-off-by: Fengguang Wu --- cpu_cooling.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -460,7 +460,7 @@ static int get_static_power(struct cpufr if (voltage == 0) { dev_warn_ratelimited(cpufreq_device->cpu_dev, "Failed to get voltage for frequency %lu: %ld\n", - freq_hz, IS_ERR(opp) ? PTR_ERR(opp) : 0); + freq_hz, PTR_ERR_OR_ZERO(opp)); return -EINVAL; }