From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Petr Mladek <pmladek@suse.cz>,
Seth Jennings <sjenning@redhat.com>,
Vojtech Pavlik <vojtech@suse.cz>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
Miroslav Benes <mbenes@suse.cz>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
mingo@kernel.org, mathieu.desnoyers@efficios.com,
oleg@redhat.com, paulmck@linux.vnet.ibm.com, andi@firstfloor.org,
rostedt@goodmis.org, tglx@linutronix.de
Subject: Re: [PATCH 2/2] livepatch: fix patched module loading race
Date: Wed, 4 Mar 2015 16:45:58 -0600 [thread overview]
Message-ID: <20150304224558.GE5464@treble.hsd1.ky.comcast.net> (raw)
In-Reply-To: <alpine.LNX.2.00.1503042258500.26925@pobox.suse.cz>
On Wed, Mar 04, 2015 at 11:02:59PM +0100, Jiri Kosina wrote:
> On Wed, 4 Mar 2015, Josh Poimboeuf wrote:
>
> > Well, we could just get a reference on all patched modules to prevent them
> > from being unloaded.
>
> Is that really a solution for cases where you are unloading a module (it
> has "just" been switched to MODULE_STATE_GOING) and enable a patch which
> patches one of its functions directly after it got switched to
> MODULE_STATE_GOING?
Ah, right. try_module_get() fails, we don't patch the module, and we
end up in the same mod->exit() race. Never mind, again :-)
--
Josh
next prev parent reply other threads:[~2015-03-04 22:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 11:38 [RFC PATCH] livepatch/module: Do not patch modules that are not ready Petr Mladek
2015-03-03 14:55 ` Josh Poimboeuf
2015-03-03 15:48 ` Petr Mladek
2015-03-03 16:01 ` Josh Poimboeuf
2015-03-03 17:34 ` Petr Mladek
2015-03-03 19:31 ` Josh Poimboeuf
2015-03-03 19:35 ` Josh Poimboeuf
2015-03-03 23:02 ` [PATCH 0/2] livepatch: fix patch module loading race Josh Poimboeuf
2015-03-03 23:02 ` [PATCH 1/2] livepatch: remove unnecessary call to klp_find_object_module() Josh Poimboeuf
2015-03-04 9:00 ` Petr Mladek
2015-03-04 21:48 ` Jiri Kosina
2015-03-03 23:02 ` [PATCH 2/2] livepatch: fix patched module loading race Josh Poimboeuf
2015-03-04 13:17 ` Petr Mladek
2015-03-04 14:18 ` Petr Mladek
2015-03-04 15:34 ` Josh Poimboeuf
2015-03-04 15:51 ` Jiri Kosina
2015-03-04 16:41 ` Josh Poimboeuf
2015-03-04 16:36 ` Petr Mladek
2015-03-04 17:57 ` Josh Poimboeuf
2015-03-04 22:02 ` Jiri Kosina
2015-03-04 22:45 ` Josh Poimboeuf [this message]
2015-03-05 0:52 ` Masami Hiramatsu
2015-03-05 14:18 ` Josh Poimboeuf
2015-03-06 1:24 ` Masami Hiramatsu
2015-03-06 10:51 ` Petr Mladek
2015-03-06 11:37 ` Masami Hiramatsu
2015-03-06 13:05 ` Petr Mladek
2015-03-06 14:43 ` Josh Poimboeuf
2015-03-05 14:24 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304224558.GE5464@treble.hsd1.ky.comcast.net \
--to=jpoimboe@redhat.com \
--cc=andi@firstfloor.org \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sjenning@redhat.com \
--cc=tglx@linutronix.de \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®