From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753513AbbCEAG1 (ORCPT ); Wed, 4 Mar 2015 19:06:27 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50277 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751474AbbCEAGZ (ORCPT ); Wed, 4 Mar 2015 19:06:25 -0500 Date: Thu, 5 Mar 2015 00:06:16 +0000 From: Mark Brown To: Bjorn Andersson Cc: Liam Girdwood , linux-kernel@vger.kernel.org Message-ID: <20150305000616.GY21293@sirena.org.uk> References: <1424994020-6698-1-git-send-email-bjorn.andersson@sonymobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UntyiZ0ghm7wS9dK" Content-Disposition: inline In-Reply-To: <1424994020-6698-1-git-send-email-bjorn.andersson@sonymobile.com> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: Silence EPROBE_DEFER error on bulk_get X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --UntyiZ0ghm7wS9dK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 26, 2015 at 03:40:20PM -0800, Bjorn Andersson wrote: > As this is already being logged elsewhere we shouldn't spam the log > unnecessarily upon EPROBE_DEFER. Where exactly is this "elsewhere" you're thinking of? I suspect you mean the core -EPROBE_DEFER logging but you don't say... > Maybe we should have a dev_dbg() for EPROBE_DEFER to aid finding which > regulator it actually was that it deferred? No, that's the wrong way around: > ret = PTR_ERR(consumers[i].consumer); > - dev_err(dev, "Failed to get supply '%s': %d\n", > - consumers[i].supply, ret); > + if (ret != -EPROBE_DEFER) > + dev_err(dev, "Failed to get supply '%s': %d\n", > + consumers[i].supply, ret); What you're saying here is that essentially everything in the probe path has to special case -EPROBE_DEFER to remove error logging which in turn means that any useful information gets elided from the logs. Having a debug level log that people can enable or dig out helps somewhat but it's not really helping users to make it harder to discover information. If you think probe deferral is too noisy then fix it, don't go and add lots of special casing code to the error handling. If other things aren't reporting errors well then fix that. --UntyiZ0ghm7wS9dK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU9534AAoJECTWi3JdVIfQoI8H/i84oet56q57Jk47I1bzinJk /1hQf06gM7IaE2y/9ayWrPlHyOtdyQdsfPFLh8pOz3HnzwznyZ5FsygxCiI2/XCP DTglX92/v6Kt1w58qfssu/Sy3MzKgSPrXxvdHHTfvUyBmoUsGN4aaoFE40cwlge9 lTt0DPuXZGAd8yXQpuAqeC9MLpICgSFzsEyra079tz9Px4k1lpbVts6HXE+VZzXv sWTKfWstfBDjEVRNhoKdw7G98obSDYlMx11rVXVGzPnIPR0t1p9jADfbWEVtJxya 8LSQPsQELSO8AAuztQHbm/jHyxmd9ZQYcQ4Gg4SCMHdpygYPW7TWDeaGcQCUQU8= =i8At -----END PGP SIGNATURE----- --UntyiZ0ghm7wS9dK--