From: Mark Brown <broonie@kernel.org>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Li.Xiubo@freescale.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH][ASoC]fsl_ssi: fix of_property_read_u32_array return value check
Date: Thu, 5 Mar 2015 01:01:20 +0000 [thread overview]
Message-ID: <20150305010120.GE21293@sirena.org.uk> (raw)
In-Reply-To: <54F77DAE.20005@maciej.szmigiero.name>
[-- Attachment #1: Type: text/plain, Size: 315 bytes --]
On Wed, Mar 04, 2015 at 10:48:30PM +0100, Maciej S. Szmigiero wrote:
> of_property_read_u32_array returns 0 on success,
> so the return value shouldn't be inverted twice,
> first on assignment then in condition expression.
>
> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-03-05 1:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 21:48 Maciej S. Szmigiero
2015-03-05 1:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305010120.GE21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®