From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755764AbbCEOEa (ORCPT ); Thu, 5 Mar 2015 09:04:30 -0500 Received: from smtprelay0202.hostedemail.com ([216.40.44.202]:42911 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755728AbbCEOE2 (ORCPT ); Thu, 5 Mar 2015 09:04:28 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::,RULES_HIT:41:355:379:541:599:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2525:2553:2560:2563:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3622:3653:3865:3866:3867:3868:3872:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4362:5007:6119:6261:7875:9025:10004:10400:10848:10967:11232:11657:11658:11914:12043:12517:12519:12740:13069:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: order09_26d521b225a46 X-Filterd-Recvd-Size: 1698 Date: Thu, 5 Mar 2015 09:04:24 -0500 From: Steven Rostedt To: Michael Ellerman Cc: shuahkh@osg.samsung.com, linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, namhyung@kernel.org Subject: Re: [PATCH] ftracetest: Don't use non-POSIX exit -1 Message-ID: <20150305090424.3b44b321@gandalf.local.home> In-Reply-To: <1425524162.32154.18.camel@ellerman.id.au> References: <1425521042-30251-1-git-send-email-mpe@ellerman.id.au> <20150304212659.3e1d1414@grimm.local.home> <1425524162.32154.18.camel@ellerman.id.au> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 05 Mar 2015 13:56:02 +1100 Michael Ellerman wrote: > > Why 255? Why not just exit 1? > > I was trying to emulate the current behaviour: > > $ /bin/bash > $ exit -1 > exit > $ echo $? > 255 Understood. > > > Actually, don't we have explicit numbers for exit status? > > > > /me not looking at the code right now to figure that out. > > Yeah looks like it, and some interesting signal handling tricks: > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/ftracetest#n123 > > I'll send a new version using "exit $FAIL" ? Yep, I figured instead of keeping current behavior, we actually fix it correctly. Thanks, -- Steve