From: Chris Dunlop <chris@onthe.net.au>
To: dev@openvswitch.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Cc: "Xu (Simon) Chen" <xchenum@gmail.com>,
Thomas Graf <tgraf@suug.ch>, Pravin Shelar <pshelar@nicira.com>,
discuss@openvswitch.org
Subject: Re: pskb_expand_head: skb_shared BUG
Date: Fri, 6 Mar 2015 14:27:44 +1100 [thread overview]
Message-ID: <20150306032744.GB5800@onthe.net.au> (raw)
In-Reply-To: <20150302004511.GA1500@onthe.net.au>
On Mon, Mar 02, 2015 at 11:45:11AM +1100, Chris Dunlop wrote:
> Heads up...
>
> We've hit this BUG() in v3.10.70, v3.14.27 and v3.18.7:
>
> net/core/skbuff.c:
> 1027 int pskb_expand_head(struct sk_buff *skb, int nhead, int ntail,
> 1028 gfp_t gfp_mask)
> 1029 {
> 1030 int i;
> 1031 u8 *data;
> 1032 int size = nhead + skb_end_offset(skb) + ntail;
> 1033 long off;
> 1034
> 1035 BUG_ON(nhead < 0);
> 1036
> 1037 if (skb_shared(skb))
> 1038 BUG(); <<< BOOM!!!
>
> This appears to be a regression in the 3.10.x stable series:
> we've been running for 11 months on v3.10.33 without problem, we
> upgraded to v3.14.27 and hit the BUG(), than again on upgrading
> to v3.18.7, then again after downgrading to v3.10.70.
Apologies, this was a false alarm.
There was indeed a regression, but it's in the upstream openvswitch code
rather than linux core. (Further details: a sharing of an
otherwise-unshared skb, causing us to hit the BUG() above, introduced in
v2.3, will be fixed in upcoming v2.3.2)
Cheers,
Chris
prev parent reply other threads:[~2015-03-06 3:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGNyuhWRNgYt=D2rEW_yPh50g-Qu2njH0zLwc4MLzNxG-OYbEw@mail.gmail.com>
[not found] ` <20150227051330.GA7198@onthe.net.au>
2015-03-02 0:45 ` Chris Dunlop
2015-03-02 1:16 ` Chris Dunlop
2015-03-06 3:27 ` Chris Dunlop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306032744.GB5800@onthe.net.au \
--to=chris@onthe.net.au \
--cc=dev@openvswitch.org \
--cc=discuss@openvswitch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=stable@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=xchenum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®