From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753552AbbCFJ25 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 Mar 2015 04:28:57 -0500
Received: from mail.skyhub.de ([78.46.96.112]:49478 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751030AbbCFJ2y (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 Mar 2015 04:28:54 -0500
Date: Fri, 6 Mar 2015 10:27:38 +0100
From: Borislav Petkov <bp@alien8.de>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: "Luck, Tony" <tony.luck@intel.com>, Prarit Bhargava <prarit@redhat.com>,
        Vivek Goyal <vgoyal@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Junichi Nomura <j-nomura@ce.jp.nec.com>,
        Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
Subject: Re: [PATCH v6] x86: mce: kexec: switch MCE handler for kexec/kdump
Message-ID: <20150306092738.GE3514@pd.tnic>
References: <3908561D78D1C84285E8C5FCA982C28F329F5837@ORSMSX114.amr.corp.intel.com>
 <20150304074117.GA30501@hori1.linux.bs1.fc.nec.co.jp>
 <3908561D78D1C84285E8C5FCA982C28F329F835A@ORSMSX114.amr.corp.intel.com>
 <20150305012447.GA16001@hori1.linux.bs1.fc.nec.co.jp>
 <20150305064509.GA16012@hori1.linux.bs1.fc.nec.co.jp>
 <20150305085735.GE3915@pd.tnic>
 <20150305093752.GA11764@hori1.linux.bs1.fc.nec.co.jp>
 <20150306025911.GA3619@hori1.linux.bs1.fc.nec.co.jp>
 <20150306083421.GD3514@pd.tnic>
 <20150306090930.GA14982@hori1.linux.bs1.fc.nec.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20150306090930.GA14982@hori1.linux.bs1.fc.nec.co.jp>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Mar 06, 2015 at 09:09:30AM +0000, Naoya Horiguchi wrote:
> I'm not sure why that works, could you elabroate it?

Because the _safe() variants are only for handling reads to possibly
non-existent MSRs. The _STATUS MSRs which you're accessing are
guaranteed to be present, otherwise __mcheck_cpu_cap_init() would've
disabled MCA on the first kernel, thus the mca_cfg.disabled check.

We can always switch to the _safe() variants later if really needed - I
just don't see the need for them right now.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--