From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755595AbbCFTTf (ORCPT ); Fri, 6 Mar 2015 14:19:35 -0500 Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:57766 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754212AbbCFTTe (ORCPT ); Fri, 6 Mar 2015 14:19:34 -0500 X-Session-Marker: 6E657665747340676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3873:3874:5007:6119:6261:7875:8603:10004:10400:10848:10967:11026:11232:11473:11658:11914:12043:12291:12296:12438:12517:12519:12555:12683:12740:13069:13138:13231:13311:13357:14093:14096:14097:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: jewel49_5349d9a67b061 X-Filterd-Recvd-Size: 2826 Date: Fri, 6 Mar 2015 14:19:31 -0500 From: Steven Rostedt To: Javi Merino Cc: acme@redhat.com, jolsa@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 2/2] tools lib traceevent: Add support for __print_array() Message-ID: <20150306141931.71f482b4@gandalf.local.home> In-Reply-To: <1425666918-11870-3-git-send-email-javi.merino@arm.com> References: <1425666918-11870-1-git-send-email-javi.merino@arm.com> <1425666918-11870-3-git-send-email-javi.merino@arm.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 6 Mar 2015 18:35:18 +0000 Javi Merino wrote: > Since 6ea22486ba46 ("tracing: Add array printing helper") trace can > traces with variable element size arrays. Add support to parse them. > > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Steven Rostedt Both patches look fine to me. You can add my: Acked-by: Steven Rostedt > Acked-by: Namhyung Kim > Signed-off-by: Javi Merino > --- > tools/lib/traceevent/event-parse.c | 93 ++++++++++++++++++++++++++++++++++++++ > tools/lib/traceevent/event-parse.h | 8 ++++ > 2 files changed, 101 insertions(+) > > + if (arg->int_array.field->type == PRINT_DYNAMIC_ARRAY) { > + unsigned long offset; > + struct format_field *field = > + arg->int_array.field->dynarray.field; > + offset = pevent_read_number(pevent, > + data + field->offset, > + field->size); > + num = data + (offset & 0xffff); Unrelated to this patch set, but we really should make that 0xffff a named define. Something like this perhaps? #define DYNAMIC_OFFSET_MASK 0xffff #define DYNAMIC_LENGTH_SHIFT 16 and even add: #define dynamic_offset(num) ((num) & DYNAMIC_OFFSET_MASK) #define dynamic_length(num) ((num) >> DYNAMIC_LENGTH_SHIFT) and use these macros instead. Again, this has nothing to do with the acceptance of this patch set. Just something that this patch set reminds me that we should do. -- Steve > + } else { > + field = arg->int_array.field->field.field; > + if (!field) { > + str = arg->int_array.field->field.name; > + field = pevent_find_any_field(event, str); > + if (!field) > + goto out_warning_field; > + arg->int_array.field->field.field = field; > + } > + num = data + field->offset;