From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755658AbbCFSqS (ORCPT ); Fri, 6 Mar 2015 13:46:18 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:42164 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752683AbbCFSqP (ORCPT ); Fri, 6 Mar 2015 13:46:15 -0500 Date: Fri, 6 Mar 2015 10:46:05 -0800 From: Brian Norris To: Valentin Rothberg Cc: akpm@linux-foundation.org, Jonathan Corbet , Ralf Baechle , David Woodhouse , Greg Kroah-Hartman , Paul Bolle , Jiri Kosina , Hannes Reinecke , Ewan Milne , Christoph Hellwig , Hongliang Tao , Huacai Chen , Nishanth Menon , Peter Ujfalusi , Santosh Shilimkar , Tony Lindgren , Rajendra Nayak , Afzal Mohammed , Keerthy , Sricharan R , Zhou Wang , Dan Carpenter , Felipe Balbi , Laurent Pinchart , Thomas Gleixner , Quentin Lambert , Arnd Bergmann , Ingo Molnar , Eyal Perry , Peter Zijlstra , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, iss_storagedev@hp.com, linux-mtd@lists.infradead.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v2] Remove deprecated IRQF_DISABLED flag entirely Message-ID: <20150306184605.GQ18140@ld-irv-0074> References: <1425560442-13367-1-git-send-email-valentinrothberg@gmail.com> <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1425565425-12604-1-git-send-email-valentinrothberg@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 05, 2015 at 03:23:08PM +0100, Valentin Rothberg wrote: > The IRQF_DISABLED is a NOOP and has been scheduled for removal since > Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove IRQF_DISABLED from > core code"). > > According to commit e58aa3d2d0cc ("genirq: Run irq handlers with > interrupts disabled") running IRQ handlers with interrupts enabled can > cause stack overflows when the interrupt line of the issuing device is > still active. > > This patch ends the grace period for IRQF_DISABLED (i.e., SA_INTERRUPT > in older versions of Linux) and removes the definition and all remaining > usages of this flag. > > Signed-off-by: Valentin Rothberg > --- > The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely > as IRQF_DISABLED is gone now; the usage in older kernel versions > (including the old SA_INTERRUPT flag) should be discouraged. The > trouble of using IRQF_SHARED is a general problem and not specific to > any driver. > > I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since > it has already been removed in linux-next by commit b0e1ee8e1405 > ("MSI-HOWTO.txt: remove reference on IRQF_DISABLED"). > > All remaining references are changelogs that I suggest to keep. > > Changelog > > v2: Correct previous change to drivers/mtd/nand/hisi504_nand.c that > broke compilation. Reported by Dan Carpenter. > --- > Documentation/scsi/ncr53c8xx.txt | 25 ------------------------- > Documentation/scsi/tmscsim.txt | 4 ---- > arch/mips/loongson/loongson-3/hpet.c | 2 +- > drivers/block/cpqarray.c | 4 ++-- > drivers/bus/omap_l3_noc.c | 4 ++-- > drivers/bus/omap_l3_smx.c | 10 ++++------ > drivers/mtd/nand/hisi504_nand.c | 3 +-- > drivers/usb/isp1760/isp1760-core.c | 3 +-- > drivers/usb/isp1760/isp1760-udc.c | 4 ++-- > include/linux/interrupt.h | 3 --- > 10 files changed, 13 insertions(+), 49 deletions(-) > For this piece: > diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c > index 289ad3ac3e80..8dcc7b8fee40 100644 > --- a/drivers/mtd/nand/hisi504_nand.c > +++ b/drivers/mtd/nand/hisi504_nand.c > @@ -758,8 +758,7 @@ static int hisi_nfc_probe(struct platform_device *pdev) > > hisi_nfc_host_init(host); > > - ret = devm_request_irq(dev, irq, hinfc_irq_handle, IRQF_DISABLED, > - "nandc", host); > + ret = devm_request_irq(dev, irq, hinfc_irq_handle, 0x0, "nandc", host); > if (ret) { > dev_err(dev, "failed to request IRQ\n"); > goto err_res; Acked-by: Brian Norris Sorry for the oversight in review, and thanks for the fixup. Brian