From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757362AbbCGLBx (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 06:01:53 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:44556 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757141AbbCGLBt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 06:01:49 -0500
Date: Fri, 6 Mar 2015 16:54:55 -0800
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: Sanjeev Sharma <sanjeev_sharma@mentor.com>,
        =?iso-8859-1?Q?Lo=EFc?= Pellegrino <oort10@gmail.com>,
        Mohammad Jamal <md.jamalmohiuddin@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192u: r8190_rtl8256: coding style and
 format string type connections
Message-ID: <20150307005455.GB11574@kroah.com>
References: <1423457188-4750-1-git-send-email-tolga.ceylan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1423457188-4750-1-git-send-email-tolga.ceylan@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Feb 08, 2015 at 08:46:28PM -0800, Tolga Ceylan wrote:
> Lines over 80 were corrected
> RT_TRACE format strings should specify unsigned instead of signed int

I don't understand, why did you do 2 different things in a single patch?

Please split this up.

Also:

>  		case RF90_PATH_C:
> -			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs, bRFSI_RFENV);
> +			u4RegValue = rtl8192_QueryBBReg(dev, pPhyReg->rfintfs,
> +				bRFSI_RFENV);

Please indent this to the character after '(' on the line above.

thanks,

greg k-h