From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753141AbbCGFlR (ORCPT ); Sat, 7 Mar 2015 00:41:17 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:39012 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752673AbbCGFlP (ORCPT ); Sat, 7 Mar 2015 00:41:15 -0500 Date: Fri, 6 Mar 2015 23:40:39 -0600 From: Felipe Balbi To: Robert Baldyga CC: , , , , Subject: Re: [PATCH] dwc3: make LPM configurable in DT Message-ID: <20150307054039.GA9568@saruman.tx.rr.com> Reply-To: References: <1425636533-30556-1-git-send-email-r.baldyga@samsung.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EeQfGwPcQSOJBaQU" Content-Disposition: inline In-Reply-To: <1425636533-30556-1-git-send-email-r.baldyga@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --EeQfGwPcQSOJBaQU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Mar 06, 2015 at 11:08:53AM +0100, Robert Baldyga wrote: > LPM capability is hardware property, so now it's moved to DT. you need a better commit log here. > Signed-off-by: Robert Baldyga > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 1 + > drivers/usb/dwc3/Kconfig | 7 ------- > drivers/usb/dwc3/core.c | 3 +++ > drivers/usb/dwc3/core.h | 1 + > drivers/usb/dwc3/host.c | 5 ++--- > drivers/usb/dwc3/platform_data.h | 1 + > 6 files changed, 8 insertions(+), 10 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentati= on/devicetree/bindings/usb/dwc3.txt > index cd7f045..36b9148 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -14,6 +14,7 @@ Optional properties: > - phys: from the *Generic PHY* bindings > - phy-names: from the *Generic PHY* bindings > - tx-fifo-resize: determines if the FIFO *has* to be reallocated. > + - usb3_lpm_capable: determines if platform is USB3 LPM capable needs a snps, prefix > @@ -848,6 +850,7 @@ static int dwc3_probe(struct platform_device *pdev) > hird_threshold =3D pdata->hird_threshold; > =20 > dwc->needs_fifo_resize =3D pdata->tx_fifo_resize; > + dwc->usb3_lpm_capable =3D pdata->usb3_lpm_capable; > dwc->dr_mode =3D pdata->dr_mode; > =20 > dwc->disable_scramble_quirk =3D pdata->disable_scramble_quirk; > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > index d201910..622f65f 100644 > --- a/drivers/usb/dwc3/core.h > +++ b/drivers/usb/dwc3/core.h > @@ -812,6 +812,7 @@ struct dwc3 { > unsigned setup_packet_pending:1; > unsigned start_config_issued:1; > unsigned three_stage_setup:1; > + unsigned usb3_lpm_capable:1; missing kdoc for this new field. > =20 > unsigned disable_scramble_quirk:1; > unsigned u2exit_lfps_quirk:1; > diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c > index 12bfd3c..507eddf 100644 > --- a/drivers/usb/dwc3/host.c > +++ b/drivers/usb/dwc3/host.c > @@ -49,9 +49,8 @@ int dwc3_host_init(struct dwc3 *dwc) > =20 > memset(&pdata, 0, sizeof(pdata)); > =20 > -#ifdef CONFIG_DWC3_HOST_USB3_LPM_ENABLE > - pdata.usb3_lpm_capable =3D 1; > -#endif > + if (dwc->usb3_lpm_capable) > + pdata.usb3_lpm_capable =3D 1; pdata.usb3_lpm_capable =3D dwc->usb3_lpm_capable; ?? drop the branch altogether > diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform= _data.h > index a3a3b6d5..a2bd464 100644 > --- a/drivers/usb/dwc3/platform_data.h > +++ b/drivers/usb/dwc3/platform_data.h > @@ -24,6 +24,7 @@ struct dwc3_platform_data { > enum usb_device_speed maximum_speed; > enum usb_dr_mode dr_mode; > bool tx_fifo_resize; > + bool usb3_lpm_capable; add kdoc for this too. --=20 balbi --EeQfGwPcQSOJBaQU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU+o9XAAoJEIaOsuA1yqREzQEP/2NkFrqp7AVkxH1SqzmY7aUW 93di44AzsmFpT9verwyPvzB107Jm98IYHztCHrrFjHdE2KdeyimAabrzWGneDC54 APevdBnnwinm2Rj5wDOEtg80aIpymVYykNbYQ32fl2J2eg1zB3cBaIB9vyWgFEOa iJC5pXW77ZkBt0dlfSC7EdqKeFHeWz+q6yywCnE/1yLoe/viotgMPeu97gplYYFV SSY9E2F921Rkob+hx4koXcO2BpaE/ODtYlF6iYMaw5GirE44aFR7EYdW5NibiM1W DnyD9yziuxZk5qOB5L9oYYGVPSDa+GVeobUwdDcUwERawX+hir6fcVBrwJgB5Wq1 S5Q++/KuGabMRQhGYw0VuLMP2sE4btpu4op4iknYxRiNdVmOmHnzkdMgi9AwJIy4 I8itSUsQBxBEJhfgGU1VTGU7QL3uQNs1kmtftJiYk5EAY80g7pZifrt+fyascX8v fuz6c0bm4UiwGpfgLTPEwrSDdmvEOHFArBkNoQ2amzyQAhqveVlERnO8/VHJaDkd OZ6fSpc8htgrxIW82jpoocll+1xIpeOb5LHIGOT+Z5SoSub3wGGvpZjRahvfEpsJ uUxLMybOLFTr9jf6RY/0Ln7foZn+U6ZrNLwqFkpsgZGL+iOZE2tk2hZGkr1C1au4 fHo2i8lZtzd9Y19ebhcE =0E8W -----END PGP SIGNATURE----- --EeQfGwPcQSOJBaQU--