From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753978AbbCGK6E (ORCPT <rfc822;w@1wt.eu>);
	Sat, 7 Mar 2015 05:58:04 -0500
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55865 "EHLO
	mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753442AbbCGK56 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 7 Mar 2015 05:57:58 -0500
Date: Sat, 7 Mar 2015 10:57:47 +0000
From: Mark Brown <broonie@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Pankaj Dubey <pankaj.dubey@samsung.com>,
        Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de
Message-ID: <20150307105747.GC28806@sirena.org.uk>
References: <1425651415-31590-1-git-send-email-p.zabel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu"
Content-Disposition: inline
In-Reply-To: <1425651415-31590-1-git-send-email-p.zabel@pengutronix.de>
X-Cookie: Editing is a rewording activity.
User-Agent: Mutt/1.5.23 (2014-03-12)
X-SA-Exim-Connect-IP: 94.175.94.161
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH] regmap: introduce regmap_name to fix syscon regmap trace
 events
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--JgQwtEuHJzHdouWu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 06, 2015 at 03:16:55PM +0100, Philipp Zabel wrote:

>  #include <linux/sort.h>
> -#include <trace/events/regmap.h>
> =20
>  #include "internal.h"
> =20
> +#include <trace/events/regmap.h>
> +

The change is basically OK but the above is a bit too funky for my
taste - it feels like it's asking for annoying compile breakage if
anyone changes anything.  I'd be more inclined to move the header
somewhere where the events stuff can see it than do this.

--JgQwtEuHJzHdouWu
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJU+tmqAAoJECTWi3JdVIfQU/EH/A8pFba/FNgs9INtZDzbKAIy
8m+lKKpurBks1FgcM+1opTOHPghMQzgz2Rw1/4KyP0OQSE/U8Z2ndCJ3lBNc2xUs
z37FXb9m8PQY2xpZWZR9XkEoZtLGFDkjf2IpLP1sbkjf1OZQsdkrN/ByIx1EMz7t
1mnKEWWHnj52siluiq1KszD4cV9jyQFkLd9ajcJZUrXDmIIWTtsxMElsiLwTmLBI
bE9OOK75zW1FbYoAkWTJzrq24x/m6n6XBpT5D5zSNwLgR59kwl8Qx3PFM18sy43E
6Csd3wZWXnMG0Yr2m3Cvz/9WqFouv6JySbQv+yOn3BJR3dpfWzfHjmubTwqhuco=
=jVnX
-----END PGP SIGNATURE-----

--JgQwtEuHJzHdouWu--