From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756602AbbCGK76 (ORCPT ); Sat, 7 Mar 2015 05:59:58 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55870 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbbCGK7y (ORCPT ); Sat, 7 Mar 2015 05:59:54 -0500 Date: Sat, 7 Mar 2015 10:59:48 +0000 From: Mark Brown To: "Ivan T. Ivanov" Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Message-ID: <20150307105948.GD28806@sirena.org.uk> References: <1425655578-22400-1-git-send-email-iivanov@mm-sol.com> <1425655578-22400-2-git-send-email-iivanov@mm-sol.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IDYEmSnFhs3mNXr+" Content-Disposition: inline In-Reply-To: <1425655578-22400-2-git-send-email-iivanov@mm-sol.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IDYEmSnFhs3mNXr+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Mar 06, 2015 at 05:26:18PM +0200, Ivan T. Ivanov wrote: > Ensure that driver is owner of the GPIO's used for CS signals. > + for (cs = 0; cs < master->num_chipselect; cs++) { > + cs_gpio = of_get_named_gpio(dev->of_node, "cs-gpios", cs); > + Any new GPIO users should really be using the gpiod API, however this is duplicating core functionality so as Stephen says why are we doing this? --IDYEmSnFhs3mNXr+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU+tojAAoJECTWi3JdVIfQhM0H/Ak3gnPPmFvukqMp5ECUWqzD RngORM9ZUb44nJtPmO53dM8l/O9Hh1oAo9srJD5IZ1CNNxFDwqlbGtFZOCbBo4i7 af+iEYZWSb32bPzCinZFI68wZOU6Cjbk0CHHIVMNmwON253LfTSUIFU4Mwl+JQ8b nZiI+7RNnHlWXdhzy8Lbrs/aQKAMx9DxBX1rmMvc7E0QUWHoPCzEDLmLnpOf6/B3 7UaKX63Sz87sXIAr51+GhsBmUrIBukGtlogLJRMHA9432Be4tQoKUg3a5+a3Tk0B dtM3cu6SglEgg5ykKO4MoYB5FIB2sA7kp7dD8TTVKWdAeldZCIias1+mwn+QXo4= =vBKV -----END PGP SIGNATURE----- --IDYEmSnFhs3mNXr+--