From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750930AbbCGQbg (ORCPT ); Sat, 7 Mar 2015 11:31:36 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56544 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750698AbbCGQbd (ORCPT ); Sat, 7 Mar 2015 11:31:33 -0500 Date: Sat, 7 Mar 2015 16:31:02 +0000 From: Mark Brown To: "Maciej S. Szmigiero" Cc: alsa-devel@alsa-project.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , Brian Austin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150307163102.GR28806@sirena.org.uk> References: <54F9F81E.8080105@maciej.szmigiero.name> <20150307105201.GB28806@sirena.org.uk> <54FB041D.8010102@maciej.szmigiero.name> <20150307143434.GL28806@sirena.org.uk> <54FB1A38.3080609@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FWibJpkbnkY6rrXF" Content-Disposition: inline In-Reply-To: <54FB1A38.3080609@maciej.szmigiero.name> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH][ASoC]Add DT bindings for generic ASoC AC97 CODEC driver X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --FWibJpkbnkY6rrXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 07, 2015 at 04:33:12PM +0100, Maciej S. Szmigiero wrote: > W dniu 07.03.2015 15:34, Mark Brown pisze: > > That's true, and it's something it's easy to get away with with board > > files, but that doesn't mean it's something we should be doing for > > device tree where we're not just finding an expedient way to load things > > but rather defining an ABI. > Do you recommend then putting AC'97 bus/mixer attach in > simple-card/fsl-asoc-card or controller driver instead? It's tricky. For the vast majority of AC'97 systems we probably want to just do things from the bus controller but there are some funky AC'97 embedded systems out there which need quirks to varying degrees, and in some cases the ASoC AC'97 drivers do a much better job on things like power. For those we'd need to do something different to just doing a standard AC'97 instantiation but what exactly we do in a DT world (quirk on machine compatible?) isn't clear. If the platform you're working on isn't one that commonly got fancy AC'97 subsystems then it's possibly best to just do the common case and only worry about what to do about the complex case if anyone has a need. --FWibJpkbnkY6rrXF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU+yfFAAoJECTWi3JdVIfQHqIH/igfGA1LZVoxjrr0WMlHv6oM ydT3h9HMoWiZO9QVDVPqeKSiIgaNGI1N+uz9PVFPfAXPmFJlBTErau3Q+zADOBqB kf+GIik/dQ/FG8iF5BV6/JTRPy2kSEb2C6Nge3pl/pYI3BfNRiAgjtblNVQa3MXL flbqLMN+KOu2J9VKthRJjLSrdHDhvKp/VvnsVus34qYIyc57xinLNQNF73e9GOjl Sf0q5fUIRHsws5adpssN4BKLd4fHzdphmcnBKonGu/FOP2xj/hjpGceaKlTWzk5c 47E9ZIcps7oR7VHC3QGb5YuZfFfoCI3u/d6bsGF4FvW5HQxV6pBUAAubrSWxyDs= =qCQf -----END PGP SIGNATURE----- --FWibJpkbnkY6rrXF--