From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbbCHLbe (ORCPT ); Sun, 8 Mar 2015 07:31:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53688 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbbCHLbb (ORCPT ); Sun, 8 Mar 2015 07:31:31 -0400 Date: Sun, 8 Mar 2015 12:31:25 +0100 From: Jean Delvare To: "Ivan.khoronzhuk" Cc: dmidecode-devel@nongnu.org, Ivan Khoronzhuk , matt.fleming@intel.com, ard.biesheuvel@linaro.org, linux-kernel@vger.kernel.org, leif.lindholm@linaro.org, Mark Salter , grant.likely@linaro.org Subject: Re: [dmidecode] [Patch v3] firmware: dmi-sysfs: add SMBIOS entry point area raw attribute Message-ID: <20150308123125.7b324e47@endymion.delvare> In-Reply-To: <54FB654C.2030601@globallogic.com> References: <1422448763-17583-1-git-send-email-ivan.khoronzhuk@linaro.org> <1422975508.18187.77.camel@deneb.redhat.com> <54D0EDE8.40207@linaro.org> <1424940642.25006.60.camel@chaos.site> <20150226104134.178e8c35@endymion.delvare> <54F6FA64.7000609@globallogic.com> <20150305084656.36d639a6@endymion.delvare> <54FB654C.2030601@globallogic.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ivan, On Sat, 07 Mar 2015 22:53:32 +0200, Ivan.khoronzhuk wrote: > On 03/05/2015 09:46 AM, Jean Delvare wrote: > > It's not just two tables (I don't expect a lot of BIOSes to provide two > > tables in practice, and they would have essentially the same format > > anyway) but more importantly two entry points. The _SM3_ entry point is > > brand new and most applications (including dmidecode) don't support it > > yet. It doesn't matter if the kernel itself can parse it, as it passes > > the raw entry point to applications anyway. > > > > It happens that we are introducing this new sysfs raw interface at the > > same time _SM3_ is being introduced, so we do not have to care about > > backwards compatibility. Both the kernel and dmidecode will need to be > > updated to support the new interface, so we can keep things simple and > > let the kernel expose only the best entry point. > > > > If the sysfs raw interface was already present at the time _SM3_ > > support was being added, then we would have had to present both entry > > points for backwards compatibility. And if some _SM4_ entry point is > > ever added in the future with a new format, we will have to export it > > as a new sysfs attribute so as to not break compatibility. > > > > As a summary, I agree that a single entry point file is OK for now, but > > only because we are lucky that the timing is right. > > Despite of timing is right. > > The specification doesn't oblige firmware to provide two entry points. > An implementation may provide either the 32-bit entry point or the 64-bit > entry point, or both. For compatibility with existing SMBIOS parsers, an > implementation should provide the 32-bit entry point, but it's not required. I expect most implementations will do, as it's trivial to implement. > Another case if specification requires to provide two entry points. Then > you can > be sure in backward compatibility. But at least for now you can't. > > It's obvious, if kernel found two entry points then it can create two > sysfs attributes. > But, what kernel should do in case if only one new entry point is present. > Generate entry point of old version..., sorry but it's bad idea. At > least because > where guarantee that we have enough information for this. Only field we > can bring > thought entry point versions is magic string _SM*_, and based on it, if util > don't support new version it can warn. It's used for differ versions and > there is nothing we can do more. I agree that the kernel should not fake an entry point which does not exist (I'm not sure if you misunderstood me but I never suggested that.) -- Jean Delvare SUSE L3 Support