From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753082AbbCHQl7 (ORCPT ); Sun, 8 Mar 2015 12:41:59 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:44804 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751902AbbCHQl4 (ORCPT ); Sun, 8 Mar 2015 12:41:56 -0400 Date: Sun, 8 Mar 2015 19:41:52 +0300 From: Mike Krinkin To: Larry Finger Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: use %*ph specifier instead of passing direct values Message-ID: <20150308164152.GA3263@kmu-tp-x230> References: <1425830070-4948-1-git-send-email-krinkin.m.u@gmail.com> <54FC7769.7050306@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <54FC7769.7050306@lwfinger.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 11:23:05AM -0500, Larry Finger wrote: > On 03/08/2015 10:54 AM, Mike Krinkin wrote: > >The %*ph specifier allows to pass a pointer and length instead of > >pushing each byte via stack. The patch converts code to use it. > > > >Signed-off-by: Mike Krinkin > > Why not use %pM as long as you are changing this code? It will > format the results in a better way. > > Larry I just thought to save original formatting, but of course %pM is better, i'll resend a new version. > > >--- > > drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > >diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c > >index 122e9b3..960a7a5 100644 > >--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c > >+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c > >@@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool > > memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN); > > } > > RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, > >- ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n", > >- eeprom->mac_addr[0], eeprom->mac_addr[1], > >- eeprom->mac_addr[2], eeprom->mac_addr[3], > >- eeprom->mac_addr[4], eeprom->mac_addr[5])); > >+ ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n", > >+ eeprom->mac_addr)); > > } > > > > static void > > >