From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbbCHRSX (ORCPT ); Sun, 8 Mar 2015 13:18:23 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:34379 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753000AbbCHRSW (ORCPT ); Sun, 8 Mar 2015 13:18:22 -0400 Date: Sun, 8 Mar 2015 20:18:18 +0300 From: Mike Krinkin To: Joe Perches Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values Message-ID: <20150308171818.GA3766@kmu-tp-x230> References: <1425832962-3305-1-git-send-email-krinkin.m.u@gmail.com> <1425834052.5898.1.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1425834052.5898.1.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 08, 2015 at 10:00:52AM -0700, Joe Perches wrote: > On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote: > > The patch converts code to use %pM specifier instead of pushing > > each byte via stack. > > Hello Mike. > > > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c > [] > > @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool > > memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN); > > } > > RT_TRACE(_module_hci_hal_init_c_, _drv_notice_, > > - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n", > > - eeprom->mac_addr[0], eeprom->mac_addr[1], > > - eeprom->mac_addr[2], eeprom->mac_addr[3], > > - eeprom->mac_addr[4], eeprom->mac_addr[5])); > > + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n", > > + eeprom->mac_addr)); > > You changed the subject and commit log but not > the patch. V3? > It was stupid fault... Sorry for noise. >